fix: make NumPy object arrays JSON-safe - #24
Open
danielgaskins wants to merge 1 commit into
Open
Conversation
Signed-off-by: Daniel Gaskins <danielgaskins99@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
to_jsonable()returned the result ofndarray.tolist()without converting its nested values. NumPy object arrays could therefore leavePath,set, and similar objects in benchmark profiles, causing checkpoint writes to fail injson.dump().Pass the resulting list through the existing recursive converter. Numeric arrays keep producing ordinary lists, while nested objects are converted using the same rules as other sequences.
Closes #23
Tests
pytest -q tests/core/test_evaluation_utils.py tests/core/test_benchmark.pygit diff --checkThe repository-wide pre-commit run also scans unchanged notebooks and currently reports existing high-entropy outputs and formatting changes outside this pull request. Those unrelated changes are not included.