feat: separate out remaining dependencies and improve tests#789
Open
jakelorocco wants to merge 3 commits intomainfrom
Open
feat: separate out remaining dependencies and improve tests#789jakelorocco wants to merge 3 commits intomainfrom
jakelorocco wants to merge 3 commits intomainfrom
Conversation
Contributor
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
jakelorocco
changed the title
jakelorocco
force-pushed
the
jal/improve-dependency-isolation-tests
branch
from
dcc97f5 to
484a590
Compare
Contributor
Author
|
@frreiss, I believe you are getting pulled in just for the changes in mellea/formatters/granite/retrievers/util.py. This is a quality of life change but let me know if you see issues with it. Thanks! |
jakelorocco
force-pushed
the
jal/improve-dependency-isolation-tests
branch
from
484a590 to
798ac76
Compare
ajbozarth
reviewed
Apr 8, 2026
planetf1
approved these changes
Apr 14, 2026
Contributor
There was a problem hiding this comment.
Tested the CLI install (following the original comments):
| Scenario | Result |
|---|---|
m (no extras) |
Friendly error: pip install "mellea[cli]" ✓ |
m --help with [cli] |
Works ✓ |
m serve script.py with [cli] only |
Friendly error: pip install "mellea[server]" ✓ |
m alora train ... with [cli] only |
Friendly error: pip install "mellea[hf]" ✓ |
m alora add-readme ... with [cli] only |
Raw ModuleNotFoundError: No module named 'huggingface_hub' ✗ |
This PR didn't touch the code in the last scenario - so opened as a followup #855
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc PR
Type of PR
Description
We no longer need to explicitly version click. Typer is better about its click versioning in its own pyproject but the error is also gone.
Finishes up the dependency isolation tests; splits cli into it's own group; and fixes up import errors and dependency separation.
CI doesn't run the dependency isolation tests; ensured they pass locally.
All nice import error messages function like our current ones. The m cli works this way as well:
Testing