Skip to content

fix: add recursive nested-model $ref resolution in Pydantic tool parameter schemas#1416

Open
akihikokuroda wants to merge 4 commits into
generative-computing:mainfrom
akihikokuroda:issue911
Open

fix: add recursive nested-model $ref resolution in Pydantic tool parameter schemas#1416
akihikokuroda wants to merge 4 commits into
generative-computing:mainfrom
akihikokuroda:issue911

Conversation

@akihikokuroda

@akihikokuroda akihikokuroda commented Jul 20, 2026

Copy link
Copy Markdown
Member

Pull Request

Issue

Fixes #911
Fixes #1105

Description

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code was added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

Attribution

  • AI coding assistants used

Adding a new component, requirement, sampling strategy, or tool?

If your PR adds or modifies one of the types below, check the matching box. A checklist of type-specific review items will be posted as a comment.

  • Component
  • Requirement
  • Sampling Strategy
  • Tool

NOTE: Please ensure you have an issue that has been acknowledged by a core contributor and routed you to open a pull request against this repository. Otherwise, please open an issue before continuing with this pull request.

Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
@github-actions github-actions Bot added the bug Something isn't working label Jul 20, 2026
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
@akihikokuroda
akihikokuroda marked this pull request as ready for review July 21, 2026 18:08
@akihikokuroda
akihikokuroda requested a review from a team as a code owner July 21, 2026 18:08
@akihikokuroda

Copy link
Copy Markdown
Member Author

This PR includes the changes in #1411.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recursively flatten nested discriminated unions in tool schemas Support recursive nested-model $ref resolution in Pydantic tool parameter schemas

1 participant