ci: add check for license/copyright headers on code files #1402
Queued
psschwei wants to merge 2 commits into
Queued
ci: add check for license/copyright headers on code files #1402psschwei wants to merge 2 commits into
psschwei wants to merge 2 commits into
Conversation
AngeloDanducci
left a comment
AngeloDanducci
left a comment
Contributor
There was a problem hiding this comment.
LGTM but will wait to approve until #1401 merges
Member
Author
On the plus side, the check is working as expected... |
markstur
reviewed
Jul 17, 2026
markstur
left a comment
markstur
left a comment
Contributor
There was a problem hiding this comment.
very tempting to suggest an existing tool, but I think we'll be happier with this one. Last one I used required go.
LGTM
AngeloDanducci
approved these changes
Jul 17, 2026
AngeloDanducci
left a comment
AngeloDanducci
left a comment
Contributor
There was a problem hiding this comment.
Pre-req finished merge queue.
markstur
approved these changes
Jul 17, 2026
markstur
left a comment
markstur
left a comment
Contributor
There was a problem hiding this comment.
Need to fix more files so it passes its own check again, but once that is fixed and passing merge it FAST
Contributor
|
Think it just needs to be rebased, the check fails exactly as many files as were merged in the required preceding PR. There are just no conflicts so no warning about it. |
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
psschwei
enabled auto-merge
July 17, 2026 21:24
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Companion to #1401
Fixes #1407
Description
Adds an additional check to quality.yml to ensure that code files have SPDX license/copyright headers (as per OSPO recommendation)
Testing
Attribution
Adding a new component, requirement, sampling strategy, or tool?
If your PR adds or modifies one of the types below, check the matching box. A checklist of type-specific review items will be posted as a comment.
NOTE: Please ensure you have an issue that has been acknowledged by a core contributor and routed you to open a pull request against this repository. Otherwise, please open an issue before continuing with this pull request.