Cicd combined#95
Open
aviv1ron1 wants to merge 25 commits into
Open
Conversation
Signed-off-by: aviv ron <rona@il.ibm.com>
Signed-off-by: aviv ron <rona@il.ibm.com>
Signed-off-by: aviv ron <rona@il.ibm.com>
Signed-off-by: aviv ron <rona@il.ibm.com>
Signed-off-by: aviv ron <rona@il.ibm.com>
Signed-off-by: aviv ron <rona@il.ibm.com>
Signed-off-by: aviv ron <rona@il.ibm.com>
Signed-off-by: aviv ron <rona@il.ibm.com>
Signed-off-by: aviv ron <rona@il.ibm.com>
Signed-off-by: aviv ron <rona@il.ibm.com>
Signed-off-by: aviv ron <rona@il.ibm.com>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
Signed-off-by: aviv ron <rona@il.ibm.com>
Signed-off-by: aviv ron <rona@il.ibm.com>
Signed-off-by: aviv ron <rona@il.ibm.com>
Ruff loads its config from pyproject.toml, so a malformed pyproject.toml makes ruff abort with a parser error instead of the clean check-toml message. Running check-toml/check-yaml first (with fail_fast) ensures syntax errors are reported by the dedicated validator, consistently between local commits and CI's --all-files run. Signed-off-by: aviv ron <rona@il.ibm.com>
check-added-large-files only inspects staged additions, so on CI's clean checkout (nothing staged) it was a no-op. --enforce-all makes it check all files under pre-commit run --all-files. uv.lock (~2.3 MB) is excluded as an intentionally large lockfile. Signed-off-by: aviv ron <rona@il.ibm.com>
check-merge-conflict returns early unless a merge is in progress, so on CI's clean checkout it was a no-op. --assume-in-merge makes it always scan, letting pre-commit run --all-files catch committed conflict markers. Signed-off-by: aviv ron <rona@il.ibm.com>
…hooks Signed-off-by: aviv ron <rona@il.ibm.com>
Signed-off-by: aviv ron <rona@il.ibm.com>
uv lock resolves fine on macOS; only installing the vLLM/CUDA wheels fails. --frozen is for not mutating the lock, not because a re-resolve would fail. Also note the uv-lock pre-commit hook runs locally. Signed-off-by: aviv ron <rona@il.ibm.com>
CI's coverage run executes only tests/unit/, which exercises just the pure-Python config module. Measuring the whole granite_switch package diluted the reported coverage to ~1%, because the hf/vllm/composer/ tutorials subpackages are GPU/model-only and unreachable in CI. Add [tool.coverage.run] omit rules for those subpackages so the CI coverage number reflects the code the unit suite is actually responsible for (now ~96%). Full-project coverage continues to be measured on the GPU cluster. Signed-off-by: aviv ron <rona@il.ibm.com>
Signed-off-by: aviv ron <rona@il.ibm.com>
Signed-off-by: aviv ron <rona@il.ibm.com>
Signed-off-by: aviv ron <rona@il.ibm.com>
Signed-off-by: aviv ron <rona@il.ibm.com>
PR ReviewStrong infrastructure PR overall — the CI/CD direction looks good and the pre-commit/dev-experience improvements are valuable. What looks good
Requested changes
Nits
Overall: good direction, but I’d request the DCO fix and clearer CI/test-coverage expectations before merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.