Repository navigation
MCP plugin: say what it can send, instead of "sends nothing" - #166
Merged
Merged
Conversation
The plugin README and manifests said it sends nothing to anyone and is "Local only", while hosted: true sends a URL to genclass.dev, GENCLASS_REPORT mirrors finding ids and verdicts to the dashboard, and genclass_scan can download the runtime from npm. Everything that leaves the machine is opt-in, so say that, and list all of it in one place. No code changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin's README and manifests say it "sends nothing to GenClass or anyone else" and is "Local only". The code does more than that, all of it opt-in:
genclass_scanwithhosted: truesends the URL to the genclass.dev page check.GENCLASS_REPORTmirrors finding ids, kinds, page paths, replay verdicts and counts to the dashboard.genclass_analytics{source: "production"}reads the dashboard whenGENCLASS_DASHBOARDis set.genclass_scandownloads@genclass/runtimefrom npm through npx when the project does not have it.An independent review of the awesome-claude-skills listing caught this, and that list's maintainer has blocked a pull request over this kind of claim. So the wording now lists what can go off the machine. The server's behaviour was read from
packages/mcp/src/scan.tsandreport.ts; no code changes.Changed: the plugin README, the package README's Privacy section, the three descriptions ("Local only" becomes "Runs on your machine; anything it sends is opt-in"),
llms-install.mdand the listing drafts indocs/adoption/listings/mcp.md.Checks:
packages/mcp/test/manifests.test.tspasses (39 tests). The rest of the suite was not run, since only text changed.Not in this PR: the skill's consent steps (it adds setup lines and installs Chromium without showing them first) and the unpinned
@genclass/runtime@betain the server. buildwithclaude's maintainer closes pull requests for those. The second needs an@genclass/mcprelease.If the Anthropic directory form was already filled in with the earlier "Data handling" text, that answer should be corrected too.
🤖 Generated with Claude Code