Conversation
- Fix getNftMetadata() to return TransactionNFTTransferMetadata instead of NFTAsset - Add NFT image URL generation for NFTAsset and TransactionNFTTransferMetadata - Update NftHead to support nullable name and remove divider (matching iOS) - Update detail screen and tests to use correct metadata type
Expose nftImageUrl on TransactionDataAggregate and populate it in GetTransactionsImpl from NFT metadata so transaction items can show NFT thumbnails. Refactor IconWithBadge/BadgedIcon to accept a composable badge (instead of a raw supportIcon) and adjust badge sizing/positioning. Update TransactionItem to use a TransactionIcon that shows an arrow direction badge for transfers (with colored circular background) and fall back to asset/NFT icon. Minor import and layout adjustments to support the new badge UI.
Replace hardcoded sizing/offset literals with named constants and expose a header image size. - Add BADGE_SIZE_RATIO and use theme.space2 for IconWithBadge badge offset/size. - Add BADGE_ICON_SCALE constant and replace hardcoded 0.65f in TransactionItem. - Add headerLargeImageSize and use paddingLarge.value for rounded corner radii in NftHead. - Make space2 public in paddings.kt so components can reuse the small spacing value. These changes consolidate magic numbers into theme/constant values for consistency and reusability across UI components.
Add a new Constants object (API_URL, ASSETS_URL) and replace hardcoded api/asset URLs across the codebase. Files updated include GatewayModule, ClientsModule, PriceWebSocketClient, IconUrlGeneration, DelegationInfo, DelegationItem, and ValidatorItem to reference Constants. Also adjust WebSocket host resolution by removing the https:// prefix when passing host, and update NFT image URL to use Constants.API_URL. This centralizes endpoint configuration to make future changes easier and avoid duplicated literals.
gemcoder21
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #18