Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

Build and bundle gemstone locally instead of prebuilt package#280

Open
0xh3rman wants to merge 4 commits intomainfrom
feature/local-gemstone-build
Open

Build and bundle gemstone locally instead of prebuilt package#280
0xh3rman wants to merge 4 commits intomainfrom
feature/local-gemstone-build

Conversation

@0xh3rman
Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the build process for the gemstone library, transitioning from consuming it as a prebuilt external dependency to building it directly within the project. This change integrates the gemstone module as a local project, enabling local compilation of its native components and Kotlin bindings, which should provide more granular control over the build process, simplify development, and potentially enhance debugging capabilities.

Highlights

  • Local Gemstone Build: The gemstone library is now built and bundled locally as a project dependency instead of being consumed as a prebuilt package, allowing for greater control over its compilation and integration.
  • New Gemstone Project Module: A new Gradle module (gemstone) has been introduced to manage the build process for the gemstone Android library, encompassing native code compilation via cargo-ndk and Kotlin binding generation using uniffi.
  • Submodule Update: The core submodule reference has been updated, likely to align with the new local gemstone build process or to incorporate other related upstream changes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates a new gemstone Android library module into the project. This involves updating the core subproject, adding the gemstone/build.gradle.kts file, modifying gemcore to depend on the new internal project, and updating gradle/libs.versions.toml and settings.gradle.kts to reflect these changes. The review highlights several areas for improvement in the new gemstone module's Gradle configuration, including refactoring task dependencies to avoid afterEvaluate, aligning the compileSdk to a stable version, enabling minification for release builds, and ensuring consistent Java and JVM target versions (Java 17) across modules, specifically with gemcore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant