Build and bundle gemstone locally instead of prebuilt package#280
Build and bundle gemstone locally instead of prebuilt package#280
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the build process for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request integrates a new gemstone Android library module into the project. This involves updating the core subproject, adding the gemstone/build.gradle.kts file, modifying gemcore to depend on the new internal project, and updating gradle/libs.versions.toml and settings.gradle.kts to reflect these changes. The review highlights several areas for improvement in the new gemstone module's Gradle configuration, including refactoring task dependencies to avoid afterEvaluate, aligning the compileSdk to a stable version, enabling minification for release builds, and ensuring consistent Java and JVM target versions (Java 17) across modules, specifically with gemcore.
No description provided.