[ENH] Refactor project_points_onto_surface for robustness and nonlinear projection support - #92
Merged
Merged
Conversation
Member
Author
This was referenced Jul 27, 2026
[FIX] Ensure tensors consistently move to backend device and add tests for GPU-specific behavior
#90
Merged
Merged
Leguark
force-pushed
the
finite_faults/projection_correctness
branch
from
September 4, 2026 13:17
f229d8c to
3bbbb63
Compare
Leguark
force-pushed
the
finite_faults/serializable_input
branch
from
September 4, 2026 13:17
4df1bc8 to
5d0a855
Compare
This was referenced Sep 4, 2026
Leguark
force-pushed
the
finite_faults/serializable_input
branch
from
September 4, 2026 13:29
5d0a855 to
b65a607
Compare
Leguark
force-pushed
the
finite_faults/projection_correctness
branch
from
September 4, 2026 13:29
3bbbb63 to
3280ecb
Compare
Leguark
marked this pull request as ready for review
September 4, 2026 13:31
Member
Author
Merge activity
|
Leguark
changed the base branch from
finite_faults/serializable_input
to
graphite-base/92
September 5, 2026 09:29
Leguark
force-pushed
the
finite_faults/projection_correctness
branch
from
September 5, 2026 09:43
3280ecb to
535b51d
Compare
Leguark
force-pushed
the
graphite-base/92
branch
from
September 5, 2026 09:43
b65a607 to
4825b3a
Compare
Leguark
changed the base branch from
graphite-base/92
to
finite_faults/serializable_input
September 5, 2026 09:43
…near projection support Refactors the `project_points_onto_surface` function to enable exact Newton-based projection for linear scalar fields and improve nonlinear field handling with residual re-evaluation requirements. Adds gradient and surface tolerance handling, error conditions for near-zero gradients, and improved validation for scalar and gradient inputs. Updates tests to validate projection correctness, idempotency, and edge cases. Enhances gradient field accessors in dense grid outputs to address inconsistencies.
Leguark
changed the base branch from
finite_faults/serializable_input
to
graphite-base/92
September 5, 2026 09:44
Leguark
force-pushed
the
finite_faults/projection_correctness
branch
from
September 5, 2026 09:44
535b51d to
0561736
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Refactors the
project_points_onto_surfacefunction to enable exact Newton-based projection for linear scalar fields and improve nonlinear field handling with residual re-evaluation requirements. Adds gradient and surface tolerance handling, error conditions for near-zero gradients, and improved validation for scalar and gradient inputs. Updates tests to validate projection correctness, idempotency, and edge cases. Enhances gradient field accessors in dense grid outputs to address inconsistencies.