Skip to content

[ENH] Refactor project_points_onto_surface for robustness and nonlinear projection support - #92

Merged
Leguark merged 1 commit into
mainfrom
finite_faults/projection_correctness
Sep 5, 2026
Merged

[ENH] Refactor project_points_onto_surface for robustness and nonlinear projection support#92
Leguark merged 1 commit into
mainfrom
finite_faults/projection_correctness

Conversation

@Leguark

@Leguark Leguark commented Jul 27, 2026

Copy link
Copy Markdown
Member

Refactors the project_points_onto_surface function to enable exact Newton-based projection for linear scalar fields and improve nonlinear field handling with residual re-evaluation requirements. Adds gradient and surface tolerance handling, error conditions for near-zero gradients, and improved validation for scalar and gradient inputs. Updates tests to validate projection correctness, idempotency, and edge cases. Enhances gradient field accessors in dense grid outputs to address inconsistencies.

@Leguark
Leguark force-pushed the finite_faults/projection_correctness branch from f229d8c to 3bbbb63 Compare September 4, 2026 13:17
@Leguark
Leguark force-pushed the finite_faults/serializable_input branch from 4df1bc8 to 5d0a855 Compare September 4, 2026 13:17
@Leguark
Leguark force-pushed the finite_faults/serializable_input branch from 5d0a855 to b65a607 Compare September 4, 2026 13:29
@Leguark
Leguark force-pushed the finite_faults/projection_correctness branch from 3bbbb63 to 3280ecb Compare September 4, 2026 13:29
@Leguark
Leguark marked this pull request as ready for review September 4, 2026 13:31

Leguark commented Sep 5, 2026

Copy link
Copy Markdown
Member Author

Merge activity

@Leguark
Leguark changed the base branch from finite_faults/serializable_input to graphite-base/92 September 5, 2026 09:29
@Leguark
Leguark force-pushed the finite_faults/projection_correctness branch from 3280ecb to 535b51d Compare September 5, 2026 09:43
@Leguark
Leguark changed the base branch from graphite-base/92 to finite_faults/serializable_input September 5, 2026 09:43
…near projection support

Refactors the `project_points_onto_surface` function to enable exact Newton-based projection for linear scalar fields and improve nonlinear field handling with residual re-evaluation requirements. Adds gradient and surface tolerance handling, error conditions for near-zero gradients, and improved validation for scalar and gradient inputs. Updates tests to validate projection correctness, idempotency, and edge cases. Enhances gradient field accessors in dense grid outputs to address inconsistencies.
@Leguark
Leguark changed the base branch from finite_faults/serializable_input to graphite-base/92 September 5, 2026 09:44
@Leguark
Leguark force-pushed the finite_faults/projection_correctness branch from 535b51d to 0561736 Compare September 5, 2026 09:44
@Leguark
Leguark changed the base branch from graphite-base/92 to main September 5, 2026 09:44
@Leguark
Leguark merged commit 67b92f5 into main Sep 5, 2026
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant