feat: rewrite client-scripts to typescript and refactor them#1236
Merged
shadowusr merged 1 commit intoApr 16, 2026
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
shadowusr
commented
Apr 13, 2026
shadowusr
commented
Apr 13, 2026
shadowusr
commented
Apr 13, 2026
shadowusr
commented
Apr 13, 2026
Member
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe95d39ae7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
sipayRT
reviewed
Apr 14, 2026
sipayRT
reviewed
Apr 14, 2026
sipayRT
approved these changes
Apr 14, 2026
shadowusr
force-pushed
the
users/shadowusr/TESTPLANE-672.client-scripts-refactor
branch
from
fe95d39 to
411330b
Compare
Member
Author
|
Fixed all issues above in #1242. Totally agree that this a weird flow — issues should be fixed here, but it's much more reliable to apply them on top of all changes & test them right away. |
shadowusr
deleted the
users/shadowusr/TESTPLANE-672.client-scripts-refactor
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's done?
@isomorphicthat are used on node's sideNew structure
Client scripts now organized in submodules/namespaces, for example, browser-utils and screen-shooter. The pattern used in each submodule:
implementation.ts— main file, a "public API" of a submodule, accessible from client-bridgeoperations.ts— high-level sub steps, used inimplementation.ts