Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Oct 19, 2026
puskuruk
force-pushed
the
nest/platform-node-shims
branch
from
October 19, 2026 20:25
368dcf1 to
d5a4a03
Compare
puskuruk
force-pushed
the
nest/platform-node-vendor
branch
from
October 19, 2026 20:25
5d218b9 to
be6383d
Compare
Collaborator
Author
|
@coderabbitai review |
|
puskuruk
force-pushed
the
nest/platform-node-shims
branch
from
October 20, 2026 04:33
d5a4a03 to
042166f
Compare
puskuruk
force-pushed
the
nest/platform-node-vendor
branch
2 times, most recently
from
October 23, 2026 01:48
beb3f1d to
aeb89ff
Compare
puskuruk
force-pushed
the
nest/platform-node-shims
branch
2 times, most recently
from
October 23, 2026 09:17
10329f6 to
b9b72d5
Compare
puskuruk
force-pushed
the
nest/platform-node-vendor
branch
from
October 23, 2026 09:17
aeb89ff to
6dbe313
Compare
puskuruk
force-pushed
the
nest/platform-node-shims
branch
from
November 10, 2026 10:57
b9b72d5 to
6e0734e
Compare
puskuruk
force-pushed
the
nest/platform-node-vendor
branch
from
November 10, 2026 10:57
2c9b517 to
73f5599
Compare
puskuruk
force-pushed
the
nest/platform-node-shims
branch
from
November 12, 2026 08:50
6e0734e to
ad478fd
Compare
puskuruk
force-pushed
the
nest/platform-node-vendor
branch
2 times, most recently
from
November 12, 2026 09:17
233a8e7 to
8c7c7a7
Compare
puskuruk
force-pushed
the
nest/platform-node-shims
branch
from
November 12, 2026 09:17
ad478fd to
72811b7
Compare
puskuruk
force-pushed
the
nest/platform-node-vendor
branch
from
November 20, 2026 22:26
8c7c7a7 to
c33d325
Compare
puskuruk
force-pushed
the
nest/platform-node-shims
branch
from
November 20, 2026 22:26
72811b7 to
987f885
Compare
puskuruk
force-pushed
the
nest/platform-node-vendor
branch
from
November 21, 2026 03:29
c33d325 to
49225bc
Compare
puskuruk
force-pushed
the
nest/platform-node-shims
branch
from
November 21, 2026 10:18
4f1d62a to
f9f9e3e
Compare
puskuruk
force-pushed
the
nest/platform-node-vendor
branch
from
November 21, 2026 10:18
49225bc to
a683a2d
Compare
puskuruk
force-pushed
the
nest/platform-node-shims
branch
from
November 21, 2026 11:09
f9f9e3e to
d9b5aa0
Compare
puskuruk
force-pushed
the
nest/platform-node-vendor
branch
from
November 21, 2026 11:09
a683a2d to
c8f3bb9
Compare
puskuruk
force-pushed
the
nest/platform-node-shims
branch
from
November 21, 2026 11:50
d9b5aa0 to
a646bda
Compare
puskuruk
force-pushed
the
nest/platform-node-vendor
branch
from
November 21, 2026 11:50
c8f3bb9 to
04c8eeb
Compare
puskuruk
force-pushed
the
nest/platform-node-shims
branch
from
November 21, 2026 12:57
a646bda to
6841fa2
Compare
puskuruk
force-pushed
the
nest/platform-node-vendor
branch
2 times, most recently
from
November 21, 2026 13:54
e30d2a2 to
79691c6
Compare
puskuruk
force-pushed
the
nest/platform-node-shims
branch
from
November 21, 2026 13:54
6841fa2 to
fe43a2a
Compare
puskuruk
force-pushed
the
nest/platform-node-vendor
branch
from
November 21, 2026 14:34
79691c6 to
90fa814
Compare
puskuruk
force-pushed
the
nest/platform-node-shims
branch
2 times, most recently
from
November 21, 2026 17:30
e86ce40 to
f5111f7
Compare
puskuruk
force-pushed
the
nest/platform-node-vendor
branch
from
November 21, 2026 17:30
90fa814 to
08c6c80
Compare
puskuruk
force-pushed
the
nest/platform-node-shims
branch
from
November 21, 2026 19:00
f5111f7 to
308699f
Compare
puskuruk
force-pushed
the
nest/platform-node-vendor
branch
from
November 21, 2026 19:00
08c6c80 to
2f08506
Compare
puskuruk
force-pushed
the
nest/platform-node-shims
branch
from
November 21, 2026 19:55
308699f to
666b6c1
Compare
puskuruk
force-pushed
the
nest/platform-node-vendor
branch
from
November 21, 2026 19:55
2f08506 to
67cac29
Compare
…s HTTPMethod (UPSTREAM-DIFF)
…pt source has no default export (UPSTREAM-DIFF)
…ams, ParsedQuery, a NodeApp class, no prototype-reassigned params object (UPSTREAM-DIFF)
…certification, with qs's Decoder and a ParsedQs scanQuery in secure-json-parse (UPSTREAM-DIFF)
…from the pinned nest commit
…de-vs-compiled probes for JSON.stringify of undefined and instanceof over an Error subclass
Re-vendor the five platform-node files from nestjs/nest feat/platform-node at 0828b0d (2026-10-24, packages at 12.2.0; pinned before: 2b10fb2, 12.1.3), carrying the typing edits listed in UPSTREAM-DIFF.md onto the rewritten router (one find-my-way tree, path-to-regexp variants for trailing slashes, literal-prefix skips, empty-segment fallbacks) and the body parser. New edits the new upstream needs under geatsc, each listed in UPSTREAM-DIFF: the `METHODS` import of `http` aliased to this target's `httpMethods`; the variant matcher's `TokenData[]` stated as `Path[]` (no conversion into the `Path | Path[]` union otherwise); `Object.assign` onto the route parameters replaced by a key loop; a second `as any` matcher cast dropped. tools/nest/build-platform-node.mjs pins 0828b0d / 12.2.0 and nest-node-probe depends on the 12.2.0 tarballs.
http gains validateHeaderName, validateHeaderValue, ServerResponse.shouldKeepAlive, the three-argument writeHead and a getHeader that returns undefined, a string or the array of values. async_hooks exports AsyncResource, NodeJS.WritableStream names the stream Writable, and Buffer.byteLength accepts an encoding for binary input as Node does.
Adds adapters/utils/hostname.util.ts and adapters/utils/on-response-close.util.ts, which the vendored adapter now imports. UPSTREAM-DIFF.md cites the 085f83a16 lines; every edit carries over unchanged.
…he tarball builder
@nestjs/platform-node is published since 12.5.0, so the probe pins @nestjs/{common,core,platform-node} 12.5.1 from the registry and tools/nest/build-platform-node.mjs, which packed them from a nest checkout, is removed.
puskuruk
force-pushed
the
nest/platform-node-shims
branch
from
November 21, 2026 20:33
666b6c1 to
633e50d
Compare
puskuruk
force-pushed
the
nest/platform-node-vendor
branch
from
November 21, 2026 20:33
67cac29 to
23cb6ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vendors the typed sources of
@nestjs/platform-nodeat nestjs/nest master 085f83a16 (v12.5.1) underruntime/node/nest, with the type-level edits whole-program strict certification needs, each listed inUPSTREAM-DIFF.mdwith the upstream lines it changes; upstream's comments are kept.apps/nest-node-probecarries the Node oracle and the node-vs-compiled probes, and installs@nestjs/{common,core,platform-node}12.5.1 from npm.The first six commits vendor 2b10fb2 (12.1.3) and its edits; 0828b0d (12.2.0) and 085f83a16 (12.5.1) follow. 12.5.1 adds
adapters/utils/hostname.util.tsandon-response-close.util.tsand reaches more ofnode:http, so one commit adds those Node surfaces first:validateHeaderName,validateHeaderValue,ServerResponse.shouldKeepAlive, the three-argumentwriteHead, agetHeaderreturningundefined, a string or the array of values,async_hooks.AsyncResource, andBuffer.byteLengthwith an encoding. Every earlier edit carries over unchanged.The packages are on npm since 12.5.0, so the last commit removes the tarball builder
tools/nest/build-platform-node.mjsthat 39ca9cf added; nothing needs a nest checkout.Builds only with compiler fixes no release carries yet: geastack/compiler#21, geastack/compiler#28, geastack/compiler#29, geastack/compiler#30, geastack/compiler#31 and geastack/compiler#33 (on main 1ae87837 / 1.0.61). Main alone refuses hello-nest at
instanceof Date(#28) and does not compileapps/hono-hello(#33, a regression since 1.0.47). Thepackage.jsonfloor moves on #4 once they are released.Verification on 49225bc with main + those PRs, macOS arm64: all 11
scripts/test-*.mjsparity probes pass (DICTIONARY_MISSING_PARITY_OK:22,ERROR_SUBCLASS_PARITY_OK:8,FS_STAT_PARITY_OK:15,HTTP_SERVER_OPTIONS_PARITY_OK:5,JSON_UNDEFINED_PARITY_OK:7,MISSING_REQUEST_HEADER_PARITY_OK,NATIVE_BROTLI_OK:8,SET_IMMEDIATE_PARITY_OK:15,STREAM_LIFECYCLE_PARITY_OK:27,URL_CAN_PARSE_PARITY_OK:170,ZLIB_STREAMS_PARITY_OK:65);tools/nestcheck 24 tables;node --test scripts/test-package.mjs6 pass.Related
Stack: #6 (1/4, shims) → this PR → #8 (3/4, AOT) → #9 (4/4, benchmark). Shows only its own twelve commits over
nest/platform-node-shims.