fix(setup): support -h/--help instead of running installer (#1133)#1219
Open
saen-ai wants to merge 1 commit intogarrytan:mainfrom
Open
fix(setup): support -h/--help instead of running installer (#1133)#1219saen-ai wants to merge 1 commit intogarrytan:mainfrom
saen-ai wants to merge 1 commit intogarrytan:mainfrom
Conversation
…1133) Before: `./setup --help` silently ran the full installer because the arg parser's catch-all (`*) shift`) swallowed unknown flags. After: `-h`/`--help` print a usage banner and exit 0. The check runs before the bun availability guard so the flag is discoverable on a fresh machine. Tests: test/setup-help.test.ts covers the usage function, ordering vs the bun check, flag coverage, and live invocation of both `./setup --help` and `./setup -h`. Existing setup-codesign tests unaffected. Fixes garrytan#1133
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1133.
Before
./setup --helpsilently ran the full installer because the arg parser's catch-all (*) shift) swallowed unknown flags. Reported by @dgrant — instinct was to check syntax with--help, got an install instead.After
-h/--helpprint a usage banner and exit 0. The check runs before the bun availability guard so the flag is discoverable on a fresh machine that hasn't installed bun yet.Tests
test/setup-help.test.tsadds 5 cases following the static-pattern convention fromtest/setup-codesign.test.ts:-h|--helpis handled before the bun availability check./setup --helpexits 0, printsUsage:, runs no installer side effects./setup -his equivalent to./setup --helpbun test test/setup-help.test.ts→ 5 pass. Existingsetup-codesigntests unaffected.Scope notes
*) shift ;;(silently swallows other unknown flags) — that's a separate behaviour worth its own discussion.setuponly, no.tmplregen needed.