Refactor docs-ng to Python and add comprehensive self-documentation#26
Merged
yeoldegrove merged 5 commits intomainfrom Apr 1, 2026
Merged
Refactor docs-ng to Python and add comprehensive self-documentation#26yeoldegrove merged 5 commits intomainfrom
yeoldegrove merged 5 commits intomainfrom
Conversation
Signed-off-by: Eike Waldt <waldt@b1-systems.de> On-behalf-of: SAP <eike.waldt@sap.com>
Signed-off-by: Eike Waldt <waldt@b1-systems.de> On-behalf-of: SAP <eike.waldt@sap.com>
✅ Deploy Preview for gardenlinux-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
|
I guess this deprecates #24 given that the build works again now, great to see! |
4 tasks
Signed-off-by: Eike Waldt <waldt@b1-systems.de> On-behalf-of: SAP <eike.waldt@sap.com>
ByteOtter
approved these changes
Apr 1, 2026
Collaborator
ByteOtter
left a comment
There was a problem hiding this comment.
Looks like it works as intended and fixes our build problem. I didn't find anything in the code that needs immediate work, so I'll approve this. Thank you. 👍🏼
4 tasks
Signed-off-by: Eike Waldt <waldt@b1-systems.de> On-behalf-of: SAP <eike.waldt@sap.com>
Signed-off-by: Eike Waldt <waldt@b1-systems.de> On-behalf-of: SAP <eike.waldt@sap.com>
a66cd56 to
bd17961
Compare
This was referenced Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor docs-ng to Python and add comprehensive self-documentation
What this PR does / why we need it:
This PR modernizes the docs-ng aggregation system by refactoring from bash scripts to a well-structured Python codebase with comprehensive test coverage, and adds complete self-documentation following the Diataxis framework.
Key Changes
1. Python Refactoring (Commit 2671824)
Replaced bash scripts with Python modules: Migrated from monolithic bash scripts (
aggregate-docs.sh,fetch-repo-docs.sh,transform_content.py) to a modular Python package insrc/aggregation/New architecture:
src/aggregate.py- Clean CLI entry pointsrc/aggregation/- Core package with separate concerns:models.py- Type-safe data classesconfig.py- Configuration I/Ofetcher.py- Repository fetching (git + local)transformer.py- Content transformationsstructure.py- Directory operationsImproved testing: Added proper test suite with unit and integration tests:
tests/unit/- Pure function tests (config, models, transformer)tests/integration/- End-to-end workflow testsCleaner project structure:
repos-config.jsonto project rootscripts/tosrc/2. Commit Locking Mechanism (Commit 2671824)
Automatic commit resolution: The
DocsFetcherclass now automatically records the resolved commit hash when fetching from git repositoriesReproducible builds: Configuration supports optional
commitfield to lock documentation to specific commits:{ "name": "gardenlinux", "ref": "docs-ng", "commit": "c4b1d8d7f878fcb3e779315d28e35fcb19ae4dfb" }Easy updates: New
make aggregate-updatecommand fetches latest commits and automatically updates lock fileBenefits:
3. Documentation Restructuring (Commit 1200581)
Created comprehensive documentation for docs-ng itself in Diataxis structure
7 documentation files added to
docs/reference/supporting_tools/docs-ng/:Tutorial:
tutorials/getting_started.md- Step-by-step setup guideHow-to:
how-to/adding-repos.md- Repository addition guideExplanation:
explanation/architecture.md- System architecture deep diveReference:
reference/technical.md- Source code and API documentationreference/testing.md- Test suite guidereference/configuration.md- Complete configuration referenceOverview:
overview/index.md- Main entry point4. Get CI green