export testresults as inlined ocm-resource#361
Conversation
gardener-prow
bot
added
area/compliance
gardener-github-actions
bot
added
the
ok-to-test
|
Should replace #343 |
heldkat
force-pushed
the
I750371-test-results-rendering
branch
from
bdecc6a to
390b7b9
Compare
| with: | ||
| blobs-directory: /tmp/blobs.d | ||
| ocm-resources: | | ||
| - name: gosec-report |
There was a problem hiding this comment.
I think the pipeline fails because this is being handled as a list, but our provider extensions are not list-based:
https://github.com/gardener/gardener-extension-provider-openstack/blob/21c32a1f896ee14030567d753bfaff18f5fb7e18/.github/workflows/build.yaml#L137
There was a problem hiding this comment.
Hm, I am not so sure this is what causes the problem. This is to my knowledge the standard implementation for the component descriptor when adding more than one ocm-resource...
There was a problem hiding this comment.
Ah, but now I see that the provider extension does not have an addition of test-build-logs at all yet. I will try to fix this first and see whether it resolves the issue...
There was a problem hiding this comment.
I am confused. How come this change is not in the master branch although it was merged? https://github.com/gardener/gardener-extension-provider-openstack/pull/1107/changes
There was a problem hiding this comment.
I am confused. How come this change is not in the master branch although it was merged? https://github.com/gardener/gardener-extension-provider-openstack/pull/1107/changes
Was apparently reverted by https://github.com/gardener/gardener-extension-provider-openstack/pull/1159/changes
There was a problem hiding this comment.
ok, I will create a new PR.
hebelsan
added
ok-to-test
heldkat
force-pushed
the
I750371-test-results-rendering
branch
from
6e314c3 to
8b4c38f
Compare
heldkat
force-pushed
the
I750371-test-results-rendering
branch
from
8b4c38f to
d305263
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hebelsan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: c1c981ba946aa60df9703752c885cf8163485fb6 |
gardener-prow
bot
added
the
approved
3 participants
How to categorize this PR?
/area compliance
/kind enhancement
/platform openstack
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: