Skip to content

style: update tag colors#55

Merged
gapry merged 1 commit intomainfrom
post-tags-css
Apr 1, 2026
Merged

style: update tag colors#55
gapry merged 1 commit intomainfrom
post-tags-css

Conversation

@gapry
Copy link
Copy Markdown
Owner

@gapry gapry commented Apr 1, 2026

No description provided.

Copy link
Copy Markdown

@amazon-q-developer amazon-q-developer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR updates tag colors from blue to red theme across the application. The CSS class name has been renamed from tag-pill to blog-post-tags and updated consistently in both the stylesheet and component. A new hover state has been added for better user interaction. All changes are style-related with no functional defects or blocking issues identified.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the styling for blog post tags, renaming the class to .blog-post-tags and adjusting colors. The review highlights that the chosen text color fails WCAG AA accessibility standards, suggests removing font-weight changes on hover to prevent layout shifts, and recommends standardizing the hover effect across the application for better consistency.

font-size: 0.8rem;
background: #252525;
color: #1890ff;
color: #c04d4d;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The contrast ratio between the text color #c04d4d and the background color #252525 (defined on line 19) is approximately 3.2:1. This fails the WCAG AA accessibility standard, which requires a minimum contrast ratio of 4.5:1 for normal text. This can make the tags difficult to read for users with low vision. Consider using a lighter shade of red to improve readability.

Comment on lines +28 to +33
.blog-post-tags:hover {
background: #121212;
color: #ff4d4f;
text-decoration: none;
font-weight: bold;
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Applying font-weight: bold on hover causes a layout shift because bold text is typically wider than regular text, which can push adjacent elements and create a jumpy user experience. Additionally, text-decoration: none is redundant here as it is already defined on the base .blog-post-tags class. It is recommended to remove these properties to maintain a stable layout.

.blog-post-tags:hover {
  background: #121212;
  color: #ff4d4f;
}


.tag-link:hover {
color: #1890ff;
color: #ff4d4f;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The hover effect for tags here (using text-decoration: underline) is inconsistent with the hover effect defined for tags in the blog post view (which uses a background color change in MarkdownRenderer.css). For a cohesive user experience, it is recommended to use a consistent hover style for tags across the application.

@gapry gapry merged commit 6cfc767 into main Apr 1, 2026
2 checks passed
@gapry gapry deleted the post-tags-css branch April 1, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant