Import json test suite - #40
Closed
ChrisJefferson wants to merge 2 commits into
Closed
ChrisJefferson wants to merge 2 commits into
ChrisJefferson wants to merge 2 commits into
Conversation
Import the upstream parsing corpus and record the current parser's deliberately lenient cases. Adapt the test work from #39 so it can land independently of the pure GAP implementation and address #4 first. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Co-Authored-By: Codex GPT-5 <noreply@anthropic.com>
Make the kernel extension optional while preserving the existing picojson behaviour. Dispatch GapToJsonString through the selected implementation as well, so the fallback remains complete after the 2.5.0 direct kernel serialiser. Compare the implementations across JSONTestSuite. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Co-Authored-By: Codex GPT-5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #40 +/- ##
==========================================
+ Coverage 96.50% 97.47% +0.96%
==========================================
Files 6 10 +4
Lines 143 791 +648
==========================================
+ Hits 138 771 +633
- Misses 5 20 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
This seems to be a rebased duplicate of PR #39 ? Maybe you meant to drop the second commit which adds the pure GAP JSON parser? |
Member
Author
|
Yes, I wanted to polish the tests first, I actually wasn't expecting this to get spotted so fast, I mainly made a PR because the CI wouldn't run on branches which aren't in PR (I could fix that directly of course!) |
Merged
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.