Skip to content

Stop relying on the order of conjugacy classes - #32

Merged
dimpase merged 1 commit into
masterfrom
fix-class-order
Nov 18, 2026
Merged

dimpase merged 1 commit into
masterfrom
fix-class-order

Conversation

@fingolfin

Copy link
Copy Markdown
Member

The classes of CharacterTable(G) need not be ordered like ConjugacyClasses(G).

The CCTab package makes them differ for every non-supersolvable group.

Assisted-by: Claude Code (Opus 5.5)

The classes of CharacterTable(G) need not be ordered like
ConjugacyClasses(G); the CCTab package makes them differ for every
non-supersolvable group. Three places paired values across the two
lists by position, or took the first class for the identity:

- ProjIrr@ paired the values of Irr(CharacterTable(G)) with class sums
  taken over ConjugacyClasses(G) and raised "wrong projectors?".
  Evaluate each character at the representatives the class sums were
  computed for.

- The option irr_chars of REPN_ComputeUsingMyMethod and
  REPN_ComputeUsingSerre paired characters from Irr(G) with
  ConjugacyClasses(G), giving multiplicities such as 1/2. Evaluate
  class functions at the representatives of the group's classes; plain
  lists of values are used as before.

- Both functions used the first entry of each irreducible character as
  its degree. GAP documents that ConjugacyClasses(G) starts with the
  identity class, but its own OrdinaryCharacterTable method allows for
  a stored list that does not, and then blocks of dimension -1 were
  requested. Ask the representation for its degree instead.

The decomposition functions never consult the table when the irreps
are passed in. Without that option they call
IrreducibleRepresentationsDixon, which in GAP up to 4.16 returns
non-homomorphisms for linear characters when the two orders differ;
that is fixed in GAP, not here.

Assisted-by: Claude Code (Opus 5.5)
@codecov

codecov Bot commented Oct 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.59%. Comparing base (3850d08) to head (e963622).

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #32       +/-   ##
===========================================
+ Coverage   54.39%   72.59%   +18.20%     
===========================================
  Files          25       25               
  Lines        1355     1361        +6     
===========================================
+ Hits          737      988      +251     
+ Misses        618      373      -245     
Files with missing lines Coverage Δ
lib/cohcfg/classsum.gi 73.83% <100.00%> (+64.48%) ⬆️
lib/mymethod.gi 100.00% <100.00%> (ø)
lib/serre.gi 81.53% <100.00%> (ø)
lib/utils.gi 68.29% <100.00%> (+1.20%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dimpase
dimpase merged commit 614f468 into master Nov 18, 2026
5 checks passed
@dimpase
dimpase deleted the fix-class-order branch November 18, 2026 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants