Repository navigation
Stop relying on the order of conjugacy classes - #32
Merged
Merged
Conversation
The classes of CharacterTable(G) need not be ordered like ConjugacyClasses(G); the CCTab package makes them differ for every non-supersolvable group. Three places paired values across the two lists by position, or took the first class for the identity: - ProjIrr@ paired the values of Irr(CharacterTable(G)) with class sums taken over ConjugacyClasses(G) and raised "wrong projectors?". Evaluate each character at the representatives the class sums were computed for. - The option irr_chars of REPN_ComputeUsingMyMethod and REPN_ComputeUsingSerre paired characters from Irr(G) with ConjugacyClasses(G), giving multiplicities such as 1/2. Evaluate class functions at the representatives of the group's classes; plain lists of values are used as before. - Both functions used the first entry of each irreducible character as its degree. GAP documents that ConjugacyClasses(G) starts with the identity class, but its own OrdinaryCharacterTable method allows for a stored list that does not, and then blocks of dimension -1 were requested. Ask the representation for its degree instead. The decomposition functions never consult the table when the irreps are passed in. Without that option they call IrreducibleRepresentationsDixon, which in GAP up to 4.16 returns non-homomorphisms for linear characters when the two orders differ; that is fixed in GAP, not here. Assisted-by: Claude Code (Opus 5.5)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #32 +/- ##
===========================================
+ Coverage 54.39% 72.59% +18.20%
===========================================
Files 25 25
Lines 1355 1361 +6
===========================================
+ Hits 737 988 +251
+ Misses 618 373 -245
🚀 New features to boost your workflow:
|
dimpase
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The classes of
CharacterTable(G)need not be ordered likeConjugacyClasses(G).The CCTab package makes them differ for every non-supersolvable group.
Assisted-by: Claude Code (Opus 5.5)