feat(install): install skill and MCP from install.sh - #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install.shnow runs"$dest" skilland"$dest" mcp installvia the new binary instead of reimplementing those steps in bash.--versiontags without those subcommands cannot abort a successful binary install.--dry-runprints the extra commands and does not execute them.--no-skill/--no-mcpskip the corresponding step (both together is binary-only).bash -s --when piping.Related Issue
Closes #104
Testing
go test ./...go vet ./...go build ./...CGO_ENABLED=0 go build -o gander .go test -count=1 -run TestInstallSh .(dry-run, stdin/curl | bashpath, opt-outs, non-fatal post-steps)shellcheck install.sh— same three pre-existing SC2155/SC2064 warnings as onmain; no new findingsNotes
GANDER_INSTALL_SKIP_MAIN=1is an internal hook so tests cansource install.shwithout runningmain. It is required because aBASH_SOURCE == $0guard would skipmainwhen the script is piped to bash (the documented one-liner).