Skip to content

fix(editor): prevent images collapsing in flex layouts #3744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bfintal merged 3 commits into from
Aug 17, 2026
Merged

fix(editor): prevent images collapsing in flex layouts #3744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
894139d
fix(editor): prevent images collapsing in flex layouts
Arukuen Aug 17, 2026
b95adc8
fix: make the tooltip above the stk-img-media-manager-button
Arukuen Aug 17, 2026
a1be924
fix: add the required empty line before the comment
Arukuen Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/block-components/image/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,22 @@
}

// Hide the size tooltip when the image resizer is too narrow.
.stk-img-resizer {
.stk-img-resizer-tooltip-container {
position: absolute;
inset: 0;
pointer-events: none;

// Keep the tooltip above the click-to-edit overlay at z-index 2.
z-index: 3;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
container-name: stk-img-resizer-tooltip;
container-type: inline-size;

.stk-resizer-tooltip {
pointer-events: auto;
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}

@container (max-width: 139px) {
@container stk-img-resizer-tooltip (max-width: 139px) {
.stk-resizer-tooltip {
display: none !important;
}
Expand Down
68 changes: 35 additions & 33 deletions src/block-components/image/image.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,39 +218,41 @@ const Image = memo( props => {
</button>
) }
{ props.hasTooltip && props.showTooltips && (
<ResizerTooltip
enableHeight={ props.enableHeight || props.enableDiagonal }
enableWidth={ props.enableWidth || props.enableDiagonal }
height={ formSize( currentHeight || props.height, props.heightUnit, false, false ) }
width={ formSize( currentWidth || props.width, props.widthUnit, false, false ) }
widthUnits={ props.widthUnits }
heightUnits={ props.heightUnits }
heightUnit={ props.heightUnit }
widthUnit={ props.widthUnit }
allowReset={ props.allowReset }
defaultWidth={ props.defaultWidth }
defaultHeight={ props.defaultHeight }
onChangeHeight={ ( { value, unit } ) => {
const size = {}
if ( typeof value !== 'undefined' ) {
size.height = value
}
if ( typeof unit !== 'undefined' ) {
size.heightUnit = unit
}
props.onChangeSize( size )
} }
onChangeWidth={ ( { value, unit } ) => {
const size = {}
if ( typeof value !== 'undefined' ) {
size.width = value
}
if ( typeof unit !== 'undefined' ) {
size.widthUnit = unit
}
props.onChangeSize( size )
} }
/>
<div className="stk-img-resizer-tooltip-container">
<ResizerTooltip
enableHeight={ props.enableHeight || props.enableDiagonal }
enableWidth={ props.enableWidth || props.enableDiagonal }
height={ formSize( currentHeight || props.height, props.heightUnit, false, false ) }
width={ formSize( currentWidth || props.width, props.widthUnit, false, false ) }
widthUnits={ props.widthUnits }
heightUnits={ props.heightUnits }
heightUnit={ props.heightUnit }
widthUnit={ props.widthUnit }
allowReset={ props.allowReset }
defaultWidth={ props.defaultWidth }
defaultHeight={ props.defaultHeight }
onChangeHeight={ ( { value, unit } ) => {
const size = {}
if ( typeof value !== 'undefined' ) {
size.height = value
}
if ( typeof unit !== 'undefined' ) {
size.heightUnit = unit
}
props.onChangeSize( size )
} }
onChangeWidth={ ( { value, unit } ) => {
const size = {}
if ( typeof value !== 'undefined' ) {
size.width = value
}
if ( typeof unit !== 'undefined' ) {
size.widthUnit = unit
}
props.onChangeSize( size )
} }
/>
</div>
Comment thread
coderabbitai[bot] marked this conversation as resolved.
) }
<div className="stk-img-resizer-wrapper" ref={ wrapperRef }>
<img
Expand Down
4 changes: 2 additions & 2 deletions src/components/resizer-tooltip/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ const ResizerTooltip = props => {
setPrevSwitchedWidth( props.width )
// At first switch, remember the width
// Calculate new width based on the current one
const imgEl = tooltipRef.current?.parentElement.querySelector( '.stk-img' )
const imgEl = tooltipRef.current?.closest( '.stk-img-resizer' )?.querySelector( '.stk-img' )
const newSize = convertSizeByUnit( props.width, unit, 'width', imgEl )
setCurrentWidth( newSize )
width = clampSize( newSize, unit )
Expand Down Expand Up @@ -162,7 +162,7 @@ const ResizerTooltip = props => {
setPrevSwitchedHeight( props.height )
// At first switch, remember the height
// Calculate new height based on the current one
const imgEl = tooltipRef.current?.parentElement.querySelector( '.stk-img' )
const imgEl = tooltipRef.current?.closest( '.stk-img-resizer' )?.querySelector( '.stk-img' )
const newSize = convertSizeByUnit( props.height, unit, 'height', imgEl )
setCurrentHeight( newSize )
height = clampSize( newSize, unit )
Expand Down
Loading