fix: positional step params no longer carry the label prefix into XML#201
Merged
fix: positional step params no longer carry the label prefix into XML#201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FmScript.SynthesizeHrParamsblindly converted every entry in the caller's param map into"{Key}: {Value}"regardless of whether the underlying step param had a display label. Steps whose params are positional (noHrLabelin their metadata) received the dict key as a literal prefix into XML.Concrete impact for MCP / external callers using
update_script_stepswith structured params:Set VariableName<Name>Name: $i</Name><Name>$i</Name>If/Else If/Exit Loop Ifcondition<Calculation>condition: $i > $limit</Calculation><Calculation>$i > $limit</Calculation>The bad XML imports into FileMaker successfully (it's structurally valid) but produces silent runtime errors because the variable name / calculation now contains an extraneous
"label: "prefix.Fix
SynthesizeHrParamsnow consultsStepMetadata.Paramsto drive output:HrLabelwhen defined; raw when notTest plan
tests/SharpFM.Tests/Scripting/FmScriptApplyTests.cscover Set Variable, If, Exit Loop If, out-of-order params, case-insensitive keys, and the update path