fix: remove Delete key shortcut for clip deletion#190
Merged
Conversation
The global Window-level KeyBinding for Delete fired regardless of focus, so pressing Delete inside the script editor deleted the entire clip instead of a character. Drop the KeyBinding entirely and remove the now-misleading InputGesture hint from the menu item. Clip deletion is still reachable via the Edit menu and the clip list context menu. Closes #158
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #158.
The Window-level
<KeyBinding Gesture="Delete" Command="{Binding DeleteSelectedClip}" />fired regardless of focus, so pressing Delete inside the script editor (or any text field) deleted the entire clip the user was editing rather than a character. Real data-loss risk.Removed the global keybinding and the corresponding
InputGesture="Delete"hint from the Edit menu item. Clip deletion remains reachable via the Edit menu and the clip-list context menu — keyboard shortcut intentionally not replaced, since destructive actions shouldn't be triggerable by a bare key.