Repository navigation
Standardize CI workflows: tests on pull requests, lint, publish - #44
Merged
Merged
Conversation
- tests.yaml: run on pull requests as well as pushes to main (and on dispatch); matrix is the requires-python floor and newest (3.11, 3.14) x highest/lowest-direct; setup-uv@v6 pins the interpreter; coverage reported (pytest-cov added to the dev group); checkout and setup-uv no longer track @master/@main. - lint.yaml replaces ruff.yaml and ty.yaml: ruff check on the whole tree (the old job linted `funlib/persistence`, a path that has not existed since the move to src/, so only tests/ was checked), ruff format --check, and ty as separate jobs. - publish.yaml: `uv build` instead of pip + setup-python@v3; v* tags. - README badges follow the renamed workflows. Co-Authored-By: Claude Mythos 5.1 <noreply@anthropic.com>
Mechanical: `ruff format .` (five files) and one import-order fix in explore.ipynb, with the pinned ruff 0.17.3, so the new lint and format checks start green. No code changes. Co-Authored-By: Claude Mythos 5.1 <noreply@anthropic.com>
The lowest pinned versions of some dependencies ship no wheels for the newest Python and their sdists do not build there, so that matrix cell cannot install. The floor interpreter still runs lowest-direct. Co-Authored-By: Claude Mythos 5.1 <noreply@anthropic.com>
Contributor
Author
|
Follow-up commit: the first CI run showed that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Tests only ran on
push, so a pull request from a fork never got a test run. The ruff job lintedfunlib/persistence, a path that has not existed since the move tosrc/: ruff warned and exited 0, so onlytests/has been linted. There was no format check, actions tracked@master/@main, and publishing went through pip +setup-python@v3.What changes
pull_request, pushes tomain, and manual dispatch. Matrix is therequires-pythonfloor and newest (3.11, 3.14) ×highest/lowest-direct.setup-uv@v6pins the interpreter,uv syncinstalls, pytest reports coverage (pytest-covis added to the dev group). The PostgreSQL service is unchanged.ruff.yamlandty.yaml:ruff check .(whole tree),ruff format --check .(new) andty check src tests, each on pull requests.uv buildinstead of pip +setup-python@v3; runs onv*tags only. ThePYPI_API_TOKENsecret is still used;id-token: writeis in place for trusted publishing once a publisher is registered on PyPI.A second commit is mechanical:
ruff format .(five files) and one import-order fix inexplore.ipynb, with the pinned ruff 0.17.3, so the new checks start green.Verified locally
ruff check .andruff format --check .: clean.ty check src tests: 10 diagnostics, the same 10 as onmain(the ty job is red onmainalready; unchanged here).pytest testson 3.11 / lowest-direct and 3.14 / highest: 134 passed, 29 skipped each (the PostgreSQL tests need the service and are skipped here).🤖 Generated with Claude Code