Make operator aware of registry certificates#58
Open
creydr wants to merge 2 commits intofunctions-dev:mainfrom
Open
Make operator aware of registry certificates#58creydr wants to merge 2 commits intofunctions-dev:mainfrom
creydr wants to merge 2 commits intofunctions-dev:mainfrom
Conversation
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using an insecure registry (like in the e2e tests), the operator is not able to get the middleware version via
func describe, asfunc describesfails internally withGet "https://kind-registry:5000/v2/": tls: failed to verify certificate: x509: certificate signed by unknown authority. This is because the operator is not aware of the custom cert of the registry.This PR addresses it and mounts the registry cert into the operator deployment as part of
make deploywhich is only used during development.