feat: add home, end, and delete cursor functionality#57
feat: add home, end, and delete cursor functionality#57funbiscuit merged 1 commit intofunbiscuit:masterfrom
Conversation
|
Hi @funbiscuit, since @BendikMann has already rebased the changes in #57, we can proceed with that PR instead. I'll close this one to avoid duplication. Thanks! |
funbiscuit
left a comment
There was a problem hiding this comment.
Can you please add some tests for new commands? Look inside tests/cli files for reference. Probably can be easily vibecoded using existing reference.
It would be also great if you add tests for --help/-h option, they're missing, that's why removal of --help/-h option was not catched by tests.
|
These new commits include tests for the control sequences added by gary7530. Additionally, and hopefully not controversally they also include changes to the behavior of control character 0x7F (DEL) to properly reflect the DEL control character instead of duplicating \b (BACKSPACE). |
funbiscuit
left a comment
There was a problem hiding this comment.
Everything is good, just some small nits.
Also please rebase your branch onto master without merge commit. You can do that with following commands:
git fetch
git reset --mixed origin/master
git add .
git commit -m "feat: home, end and delete"So I can merge it via github and it understands that I used your commit instead of mine.
|
Commits have been squashed as requested |
|
Merged into master, thanks for your contribution! |
This is a continuation of the pull request @gary7530 initially submitted, but did not complete the merge that @funbiscuit requested.
@gary7530's original pull request:
Please let me know if any additional changes are required.