Skip to content

fix: add the try-with-resource when use URLClassLoader #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2025
Merged

fix: add the try-with-resource when use URLClassLoader #2

merged 1 commit into from
Dec 2, 2025
+17 −15

Conversation

@amusarra
Copy link
Contributor

@amusarra amusarra commented Dec 1, 2025

Wrap URLClassLoader creation in try-with-resources to ensure it's closed and avoid leaks.

@amusarra amusarra requested a review from fugerit79 December 1, 2025 12:56
@amusarra amusarra force-pushed the pr/fix-urlclassloader-37061fb branch from 8c79214 to f5c0fa8 Compare December 2, 2025 11:50
@fugerit79 fugerit79 changed the base branch from main to develop December 2, 2025 11:54
fugerit79
fugerit79 approved these changes Dec 2, 2025
View reviewed changes
Copy link
Member

@fugerit79 fugerit79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @amusarra .

This is more robust for sure.

@fugerit79 fugerit79 merged commit dcf24b9 into fugerit-org:develop Dec 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fugerit79 fugerit79 fugerit79 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amusarra @fugerit79