Fix storage options nested under the outermost protocol - #567
Open
Laurent2916 wants to merge 2 commits into
Open
Laurent2916 wants to merge 2 commits into
Laurent2916 wants to merge 2 commits into
Conversation
fsspec.core.url_to_fs takes options nested under the protocol of every filesystem of a urlpath, the outermost one included. UPath keeps the outermost dict as a literal key and ignores it.
FSSpecChainParser.unchain popped the options nested under the first protocol before merging in the flat storage options, so the pop never found them. Merge them first, and let flat options take precedence, like fsspec.core._un_chain.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #566
FSSpecChainParser.unchainpopped the options nested under the first protocol before merging in the user's storage options, so it never found them. This merges them into the flat options first, with flat options taking precedence, likefsspec.core._un_chain.Because this matches fsspec, a urlpath without
::changes too:UPath("memory://a", memory={...})now unpacks the dict.