Remove duplicate FsUnit reference and update Microsoft.NET.Test.Sdk - #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/Tests/Tests.fsprojreferenced FsUnit twice in the same ItemGroup (6.0.1 and 5.6.1) without a condition, which is why Dependabot kept proposing a 5.6.1 -> 6.0.1 bump (#204) that would have left two identical entries behind. Removes the stale 5.6.1 line instead.Also updates Microsoft.NET.Test.Sdk 17.11.1 -> 17.12.0 in both test projects, superseding #209 (closed by Dependabot). Notes for future bumps:
Microsoft.NET.Test.Sdk doesn't support net6.0), so 17.12.0 is the ceiling until the test projects move to net8.0.Test.CSharp.csprojcarries its own Test.Sdk reference; bumping onlyTests.fsprojtriggers NU1605. That is why the single-project Dependabot PRs never went green.