Ensure ignoring a hint from config works

src/FSharpLint.Core/Application/Lint.fs

@@ -404,7 +404,7 @@ module Lint =
                           ReportLinterProgress = projectProgress }
 
                     let isIgnoredFile filePath =
-                        config.ignoreFiles
+                        config.IgnoreFiles
                         |> Option.map (fun ignoreFiles ->
                             let parsedIgnoreFiles = ignoreFiles |> Array.map IgnoreFiles.parseIgnorePath |> Array.toList
                             Configuration.IgnoreFiles.shouldFileBeIgnored parsedIgnoreFiles filePath)

src/FSharpLint.Core/Framework/Rules.fs

@@ -3,22 +3,14 @@
 open FSharp.Compiler.SyntaxTree
 open FSharp.Compiler.Range
 open FSharp.Compiler.SourceCodeServices
-open FSharpLint.Framework.AbstractSyntaxArray
 open FSharpLint.Framework.Ast
 open FSharpLint.Framework.Suggestion
 
-// Non-standard record field names for serialization
-// fsharplint:disable RecordFieldNames
 type GlobalRuleConfig =
-    {
-        numIndentationSpaces:int
-    }
+    { NumIndentationSpaces:int }
 with
     static member Default =
-        {
-            GlobalRuleConfig.numIndentationSpaces = 4
-        }
-// fsharplint:enable RecordFieldNames
+        { GlobalRuleConfig.NumIndentationSpaces = 4 }
 
 type AstNodeRuleParams =
     { AstNode:AstNode

src/FSharpLint.Core/Rules/Formatting/PatternMatchFormatting/PatternMatchClauseIndentation.fs

@@ -23,7 +23,7 @@ let check (config:Config) (args:AstNodeRuleParams) matchExprRange (clauses:SynMa
             |> Option.bind (fun firstClause ->
                 let clauseIndentation = ExpressionUtilities.getLeadingSpaces firstClause.Range args.FileContent
                 if isLambda then
-                    if clauseIndentation <> matchStartIndentation + args.GlobalConfig.numIndentationSpaces then
+                    if clauseIndentation <> matchStartIndentation + args.GlobalConfig.NumIndentationSpaces then
                         { Range = firstClause.Range
                           Message = Resources.GetString("RulesFormattingLambdaPatternMatchClauseIndentationError")
                           SuggestedFix = None

src/FSharpLint.Core/Rules/Formatting/PatternMatchFormatting/PatternMatchExpressionIndentation.fs

@@ -19,7 +19,7 @@ let check (args:AstNodeRuleParams) _ (clauses:SynMatchClause list) _ =
             guard
             |> Option.map (fun expr -> expr.Range.EndLine)
             |> Option.defaultValue pat.Range.EndLine
-        if expr.Range.StartLine <> matchPatternEndLine && exprIndentation <> clauseIndentation + args.GlobalConfig.numIndentationSpaces then
+        if expr.Range.StartLine <> matchPatternEndLine && exprIndentation <> clauseIndentation + args.GlobalConfig.NumIndentationSpaces then
             { Range = expr.Range
               Message = Resources.GetString("RulesFormattingMatchExpressionIndentationError")
               SuggestedFix = None

src/FSharpLint.Core/Rules/Formatting/UnionDefinitionIndentation.fs

@@ -23,7 +23,7 @@ let checkUnionDefinitionIndentation (args:AstNodeRuleParams) typeDefnRepr typeDe
         | [_] -> Array.empty
         | firstCase :: _ ->
             let indentationLevelError =
-                if getUnionCaseStartColumn firstCase - 2 <> typeDefnStartColumn + args.GlobalConfig.numIndentationSpaces then
+                if getUnionCaseStartColumn firstCase - 2 <> typeDefnStartColumn + args.GlobalConfig.NumIndentationSpaces then
                     { Range = firstCase.Range
                       Message = Resources.GetString("RulesFormattingUnionDefinitionIndentationError")
                       SuggestedFix = None

src/FSharpLint.Core/Rules/Typography/Indentation.fs

@@ -154,7 +154,7 @@ let checkIndentation (expectedSpaces:int) (line:string) (lineNumber:int) (indent
         None
 
 let runner context args =
-    checkIndentation args.GlobalConfig.numIndentationSpaces args.Line args.LineNumber context
+    checkIndentation args.GlobalConfig.NumIndentationSpaces args.Line args.LineNumber context
     |> Option.toArray
 
 let rule =

tests/FSharpLint.Console.Tests/TestApp.fs

@@ -95,3 +95,59 @@ type TestConsoleApplication() =
 
         Assert.AreEqual(0, returnCode)
         Assert.AreEqual(Set.empty, errors)
+
+    /// Regression test for: https://github.com/fsprojects/FSharpLint/issues/466
+    /// Hints listed in the ignore section of the config were not being ignored.
+    [<Test>]
+    member __.``Ignoring a hint in the configuration should stop it from being output as warning.``() =
+        let input = """
+        let x = [1; 2; 3; 4] |> List.map (fun x -> x + 2) |> List.map (fun x -> x + 2)
+        """
+
+        let (returnCode, errors) = main [| "lint"; input |]
+
+        // Check default config triggers the hint we're expecting to ignore later.
+        Assert.AreEqual(-1, returnCode)
+        Assert.AreEqual(Set.ofList ["`List.map f (List.map g x)` might be able to be refactored into `List.map (g >> f) x`."], errors)
+
+        let config = """
+        {
+            "hints": {
+                "add": [],
+                "ignore": [
+                    "List.map f (List.map g x) ===> List.map (g >> f) x"
+                ]
+            }
+        }
+        """
+        use config = new TemporaryFile(config, "json")
+
+        let (returnCode, errors) = main [| "lint"; "--lint-config"; config.FileName; input |]
+
+        Assert.AreEqual(0, returnCode)
+        Assert.AreEqual(Set.empty, errors)
+
+    /// Regression test for bug discovered during: https://github.com/fsprojects/FSharpLint/issues/466
+    /// Adding a rule to the config was disabling other rules unless they're explicitly specified.
+    [<Test>]
+    member __.``Adding a rule to a custom config should not have side effects on other rules (from the default config).``() =
+        let config = """
+        {
+            exceptionNames: {
+                enabled: false
+            }
+        }
+        """
+        use config = new TemporaryFile(config, "json")
+
+        // Should trigger warning for InterfaceNames rule.
+        let input = """
+        type Signature =
+            abstract member Encoded : string
+            abstract member PathName : string
+        """
+
+        let (returnCode, errors) = main [| "lint"; "--lint-config"; config.FileName; input |]
+
+        Assert.AreEqual(-1, returnCode)
+        Assert.AreEqual(Set.ofList ["Consider changing `Signature` to be prefixed with `I`."], errors)