Improve test coverage for JSON Runtime Helpers and BaseTypes.HtmlDocument #1581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s.HtmlDocument This commit significantly improves test coverage for two previously untested areas: **JSON Runtime Helpers (FSharp.Data.Json.Core)** - Added 5 comprehensive test methods targeting the private Helpers module - Tests exercise edge cases for inRangeDecimal, inRangeFloat, isIntegerDecimal, and isIntegerFloat functions - Coverage includes boundary value testing for Int32/Int64 ranges - Tests integer detection for both decimal and float values - Added floating-point precision and special value handling (NaN, infinity) **BaseTypes.HtmlDocument (FSharp.Data.Html.Core)** - Created new test file with 16 comprehensive test methods - Tests all HtmlDocument class methods: Create, Html property, GetTable, GetList, GetDefinitionList - Coverage includes error handling, malformed HTML parsing, multiple elements - Tests both includeLayoutTables true/false scenarios - Added exception testing for missing elements **Test Framework Integration** - All tests use NUnit framework with FsUnit assertions - Tests follow existing project patterns and conventions - Added appropriate compiler warnings suppression for BaseTypes methods - All tests pass successfully with proper F# type safety **Coverage Impact** - Baseline: 42.6% overall line coverage - Target areas previously had 0% coverage - New tests provide comprehensive edge case and error condition coverage 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR systematically improves test coverage by adding comprehensive tests for two previously untested areas with 0% coverage:
• JSON Runtime Helpers (FSharp.Data.Json.Core) - Added 5 test methods covering private helper functions through public API edge case testing
• BaseTypes.HtmlDocument (FSharp.Data.Html.Core) - Added new test file with 16 test methods covering all HtmlDocument functionality
Coverage Analysis
Before
inRangeDecimal,inRangeFloat,isIntegerDecimal,isIntegerFloat)Create,Html,GetTable,GetList,GetDefinitionList)Improvements Made
JSON Runtime Helpers Testing
inRangeDecimal/inRangeFloatfunctionsisIntegerDecimal/isIntegerFloatJsonConversionsAPI using strategic edge casesBaseTypes.HtmlDocument Testing
KeyNotFoundException)includeLayoutTablestrue/false scenariosTest Details
Files Changed
tests/FSharp.Data.Core.Tests/JsonConversions.fs: Added 93 lines with 5 new test methodstests/FSharp.Data.Core.Tests/BaseTypesHtmlDocument.fs: New file with 258 lines, 16 test methodstests/FSharp.Data.Core.Tests/FSharp.Data.Core.Tests.fsproj: Added new test file to compilationTechnical Implementation
#nowarn "10001"for BaseTypes methods intended for generated codeTest Plan
✅ All tests pass: 16/16 BaseTypes.HtmlDocument tests pass
✅ JSON tests verified: 5/5 new JsonConversions tests pass with edge cases
✅ Build successful: No compilation errors or warnings
✅ Coverage collection: Updated coverage report generated successfully
Quality Assurance
Related Issues
🤖 Generated with Claude Code