Skip to content

Conversation

@smoothdeveloper
Copy link
Contributor

I'm looking to use the html parsing DSL without the encumbering that active pattern brings in terms of using those to "avoid breaking changes" in the DU definitions, costing in terms of tooling and ways to do the matching using it.

For now, this is just so people can make their own build by flipping a tag in the fsproj, but we may consider having something similar to https://github.com/fsprojects/FSharp.Data.SqlClient/blob/c6e48a47eb1d64c7de7596bae3cb50a548592357/src/SqlClient/DataTable.fs#L10 as default, and provide the same package with "HIddenRepresentation" suffix to the nuget package name, for those that feel their code will be more resilient to this library changing things.

related: #1227, #1102, fsharp/fslang-suggestions#1341

…ng representation without having to hack the code itself.
@dsyme dsyme closed this Jan 15, 2025
@dsyme dsyme reopened this Jan 15, 2025
@dsyme dsyme closed this Mar 21, 2025
@dsyme dsyme reopened this Mar 21, 2025
@github-actions
Copy link
Contributor

🏥 CI Failure Analysis - Run #249

Issue: Both CI jobs (Ubuntu & Windows) failed on the CheckFormat step.

Root Cause: The file build/build.fs needs formatting.

Solution: Run the formatter command to fix the formatting:

dotnet run --project build/build.fsproj -- -t Format

Then commit the formatted changes to fix the CI build.

Error Details:

  • Error: "Some files need formatting, run dotnet run --project build/build.fsproj -- -t Format to format them"
  • Both build-ubuntu and build-windows jobs failed at step "Build and test"
  • The CheckFormat target prevents the build from proceeding when code formatting doesn't match Fantomas standards

AI-generated content by CI Failure Doctor may contain mistakes.

@dsyme
Copy link
Contributor

dsyme commented Sep 1, 2025

@pr-fix


🤖 Workflow run triggered by this comment

Fixed formatting in build/build.fs to comply with Fantomas standards.
This resolves the CI CheckFormat failure.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025

✅ CI Fix Applied

I've successfully fixed the CI formatting failure by running the Fantomas formatter on build/build.fs.

Changes Made:

  • Fixed formatting in build/build.fs: Reformatted the docProjects list and string concatenation to comply with Fantomas standards
  • Verified the fix: Ran CheckFormat target which now passes with "No files need formatting"

Root Cause:

The CI was failing on the CheckFormat step because the code in build/build.fs didn't match the project's Fantomas formatting standards.

Solution:

Ran dotnet run --project build/build.fsproj -- -t Format which automatically fixed the formatting issues.

The CI should now pass the CheckFormat step. ✅

AI-generated content by PR Fix may contain mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants