Conversation
Safe option-returning variants of TaskSeq.max/min that return None for empty sequences instead of raising ArgumentException. Follows established 'try' patterns (tryHead, tryLast, tryExactlyOne, etc.) and mirrors F# 8's Seq.tryMax/Seq.tryMin. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dsyme
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
Adds
TaskSeq.tryMaxandTaskSeq.tryMin— safe, option-returning variants ofTaskSeq.maxandTaskSeq.minthat returnNoneinstead of raisingArgumentExceptionwhen the input sequence is empty.Motivation
TaskSeq.maxandTaskSeq.minthrowArgumentExceptionon empty sequences (matchingSeq.max/Seq.minbehaviour). Atry-prefixed variant follows the established pattern in this library (tryHead,tryLast,tryExactlyOne,tryItem,tryFind,tryPick, ...) and mirrors F# 8'sSeq.tryMax/Seq.tryMin.Implementation
TaskSeqInternal.fs: addstryMaxMinhelper — same loop asmaxMinbut usesMoveNextAsync()directly for the first element, returningSome accorNoneinstead of raisingTaskSeq.fs: two one-liners delegating toInternal.tryMaxMinTaskSeq.fsi: XML-documented signatures fortryMaxandtryMinTaskSeq.MaxMin.Tests.fs: 10 new tests in aTryMaxMinmodule covering null, empty variants, singleton, immutable variants (viaTestImmTaskSeq), agreement withmax/min, and side-effect re-iterationTest Status
Formatting verified clean (
dotnet fantomas . --checkexit 0).Closes nothing — this is a new API addition.