Here are some bugfixes, and a few features for serio #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 1, 2017 13:26
This will set a timeout for read operations on the serial port. The intention is to prevent serio from hanging in certain situations. Signed-off-by: Tim Bird <tim.bird@sony.com>
The data needs to be accumulated in this routine, when used with the 'count' option. Without this fix the routine only returns one byte of data (the last byte read). Signed-off-by: Tim Bird <tim.bird@sony.com>
Don't use self.serial (even though it's available), but use self.fp, as that's consistent with the rest of the code.
The prevents data overruns when doing putfile on my setup, with io_time=0. This is faster (and likely more robust) than using io_time as a delay, but still prevents overruns on the target, when doing a putfile. Performance to put a 10000-byte file is: -P (io_time 0.1) => 41 seconds -t 0.05 (io_time 0.05) => 21 seconds waiting for prompt, but using io_time=0 => 7 seconds With io_time=0 and no wait for the prompt, serio hangs with the target stuck at the secondary shell prompt on my setup (beaglebone black, connected via Sony debug board). The target misses some of the data, and since it is in the middle of an echo of quoted material, the second quote is missed. Signed-off-by: Tim Bird <tim.bird@sony.com>
This prints a time-stamped line for most of the interactions with the target. This is handy to see what gets sent to the target, and when it is sent. It's very verbose, and can only be turned on by changing the definition of "debug" in the source. To turn it on, change the line to "debug = 1". Signed-off-by: Tim Bird <tim.bird@am.sony.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Frank,
Here are a few bugfixes and new features for serio.
The most important of these is f57c90a to read the prompt after each transmitted line.
It works for me here, but I would appreciate it if you could give it a test on your system.
This significantly reduces hangs during putfile on my setup here.
Thanks,
-- Tim