(fix) use generic API selector instead of Android API#383
Closed
leonjza wants to merge 1 commit intofrida:mainfrom
Closed
(fix) use generic API selector instead of Android API#383leonjza wants to merge 1 commit intofrida:mainfrom
leonjza wants to merge 1 commit intofrida:mainfrom
Conversation
Contributor
Author
|
Ah, saw too late, this is a dupe of #382 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this patch, using HotSpot would fail inside of
Java.perform()with errors like:On a JVM target,
android.getApi()returns null, so the firstJava.*call that builds a class model fails tries to destructjvmtifrom that null API object. This change switches class-model.js to importgetApi()from lib/api.js instead of via lib/android.js, which is already the bridge's backend selector.android.getApi()jvm.getApi()