-
-
Notifications
You must be signed in to change notification settings - Fork 107
refactor(transport): replace handshake pipeline #2065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sanity
wants to merge
34
commits into
main
Choose a base branch
from
stack/connect-transport-rewrite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,273
−4,624
Open
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
b9d43f2
fix: add update fallback propagation
sanity f72b27c
fix(update): keep local subscribers and add PUT ack tracing
sanity 6f7a90a
fix(update): remove GET fallback propagation
sanity a3ce0c5
style(update): use direct equality in allow-self check
sanity 6fa3d4b
feat: harden subscription routing
sanity 067b91f
fix(put): preserve upstream during broadcast
sanity 0a1a2f5
fix(put): deliver SuccessfulPut directly to origin
sanity 75fc24e
fix(put): send direct ack to origin on final hop
sanity 422f5f5
fix(put): ensure broadcast hop acks original origin
sanity c9ecc2d
fix(core): drain peer connection channel before waiting
sanity 67a0288
fix(network): prevent peer connection listener send starvation
sanity 452a6fd
refactor(transport): replace handshake pipeline
sanity abb6a30
ci: add river six-peer regression
sanity b5123a5
ci: run six-peer regression on ubuntu runners
sanity 5db0a72
ci: run six-peer regression on ubuntu runners
sanity 2c1749a
ci: fix river checkout paths
sanity 836d7fc
ci: use absolute paths for river workflow
sanity 3b64f0b
ci: checkout freenet-core at workspace root
sanity 1e1aff4
ci: use absolute workspace paths
sanity 601e6f3
ci: debug river workspace layout
sanity 03232c4
ci: checkout river into dedicated folder
sanity 00b66d4
ci: simplify river checkout
sanity 41b5cbf
ci: run river test from repo root
sanity b28a9e0
ci: run river tests from main workspace
sanity ae69695
ci: run river message_flow from repo root
sanity b8184c9
ci: checkout freenet-test-network
sanity 140fa41
ci: link freenet-test-network dependency
sanity 2ca74cb
ci: rely on crates.io test network
sanity e6f79cf
fix: avoid PUT forward panic before location assigned
sanity 4fa8bc8
fix(connect): add shutdown handle for initial join task
sanity c518296
fix: remove unused oneshot import
sanity 5003947
ci: merge main into stack/connect-transport-rewrite
sanity 2b64641
ci: merge origin/main into stack/connect-transport-rewrite
sanity 99e6d7f
build(macros): restore darling 0.21
sanity File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| name: six-peer-regression | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| push: | ||
| branches: | ||
| - stack/connect-transport-rewrite | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this shouldn't be necessary |
||
| - main | ||
| pull_request: | ||
| branches: | ||
| - main | ||
|
|
||
| jobs: | ||
| river-six-peer: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 120 | ||
| steps: | ||
| - name: Checkout freenet-core | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Checkout river | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: freenet/river | ||
| ref: main | ||
| path: river-src | ||
|
|
||
| - name: Install Rust | ||
| uses: actions-rs/toolchain@v1 | ||
| with: | ||
| profile: minimal | ||
| toolchain: stable | ||
| override: true | ||
|
|
||
| - name: Run six-peer regression | ||
| working-directory: river-src | ||
| env: | ||
| FREENET_CORE_PATH: ${{ github.workspace }} | ||
| RUST_LOG: info | ||
| run: | | ||
| cargo test --test message_flow river_message_flow_over_freenet_six_peers_five_rounds -- --ignored --exact | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we pull this within the ubertest definition to not have yet another pipeline?