Skip to content

Fix plus decoding in URL search hashes#2695

Open
puneetdixit200 wants to merge 1 commit into
freeCodeCamp:mainfrom
puneetdixit200:fix-url-search-plus-hash
Open

Fix plus decoding in URL search hashes#2695
puneetdixit200 wants to merge 1 commit into
freeCodeCamp:mainfrom
puneetdixit200:fix-url-search-plus-hash

Conversation

@puneetdixit200
Copy link
Copy Markdown

Summary

  • add a hash-fragment decoder that preserves literal + characters
  • use it for URL search hash parsing in both Search and SearchScope
  • cover scoped C++ URL searches and encoded literal plus queries with a focused Node test

Fixes #2463.

Tests

  • node --test test/assets/search_hash_test.js
  • node --check assets/javascripts/lib/util.js && node --check assets/javascripts/views/search/search.js && node --check assets/javascripts/views/search/search_scope.js && node --check test/assets/search_hash_test.js
  • git diff --check

Not run locally: bundle exec rake because this checkout requires Ruby 4.0.5 and Bundler 4.0.12, while this machine only has system Ruby 2.6.10 and no matching Bundler.

@puneetdixit200 puneetdixit200 requested a review from a team as a code owner June 4, 2026 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Searching C++ doc by URL is broken

1 participant