New docs: Lit (JavaScript library for web components, 20k stars) #2606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As requested in: * https://trello.com/c/PVnfdeaN#comment-665fffaa2798a59513617915 * https://trello.com/c/PVnfdeaN#comment-60a7c84181482c8dce7d0f55 In a period of one year, it went from 17k to 20k stars on GitHub. This is my first time contributing to devdocs, it took me an entire day to learn how to write a new scraper and new filters for this documentation, including the time spent fine-tuning the result.
Contributor
Author
|
Note: the only image that required increasing the We may decide to lower this size limit and let that image be loaded over the web instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in:
In a period of one year, it went from 17k to 20k stars on GitHub.
This is my first time contributing to devdocs, it took me an entire day to learn how to write a new scraper and new filters for this documentation, including the time spent fine-tuning the result.
I think this scraper is already in a good enough state to be shipped. Minor tweaks are likely possible, and such tweaks could either be done before merging this PR or done in a later PR.
If you’re adding a new scraper, please ensure that you have:
public/icons/your_scraper_name/directory:16.png: a 16×16 pixel icon for the doc16@2x.png: a 32×32 pixel icon for the docSOURCE: A text file containing the URL to the page the image can be found on or the URL of the original image itself