Skip to content

chore(.github): add zip for ci + render handbook/foundations section again#4

Merged
moT01 merged 3 commits into
mainfrom
chore_ci-tooling-zip
Jul 1, 2026
Merged

chore(.github): add zip for ci + render handbook/foundations section again#4
moT01 merged 3 commits into
mainfrom
chore_ci-tooling-zip

Conversation

@ShaunSHamilton

Copy link
Copy Markdown
Contributor

Summary

zip is needed for all builds.

Type of change

  • feat — new behavior
  • fix — bug fix
  • refactor — no behavior change
  • docs — documentation only
  • chore / ci / build — tooling, infra
  • test — tests only

Pre-flight checklist

  • pnpm changeset added (skip for chore / docs / test / ci-only PRs)
  • pnpm test, pnpm typecheck, pnpm lint, pnpm format:check clean locally
  • Visual goldens refreshed if UI changed (pnpm test:visual:update on macOS;
    Linux goldens regenerated via the Playwright Docker image — see
    docs/runbooks/deploy-docs.md)
  • apps/docs/public/{_headers,_redirects,robots.txt} unchanged or
    rebaselined deliberately
  • ADR added or updated if a locked decision changes (see
    docs/adr/README.md)

@ShaunSHamilton

Copy link
Copy Markdown
Contributor Author

Sorry for the extra work, @raisedadead . Would you mind looking into this?

I cannot use playwright locally. So, I am unsure if the snapshots just need updating, or this is indicative of another problem.

@moT01

moT01 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

I only looked at a few of the failing tests here - looks like a lot of screenshots are probably missing - Expect "toHaveScreenshot(drawer-open.png)" - that file doesn't exist - there's some similar files: drawer.spec.ts/drawer-open-mobile-darwin.png and drawer.spec.ts/drawer-open-mobile-linux.png. Saw a number of other similar failing screenshots tests. There were a few others I looked at that couldn't find locators - cause they didn't seem to exist - waiting for locator('section#brand') - let me know if you want to pair up on it at all.

@moT01

moT01 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

k, I took another look at this. Turns out those screenshot filenames are correct. The issue was that the handbook/foundations section wasn't rendering:

images

Before:
Screenshot 2026-06-24 at 1 11 14 PM

After:
Screenshot 2026-06-24 at 1 10 54 PM

Not sure if that was intentional - probably not, since the files are there. The line I added makes them render again. Not sure what made the asset-kit.zip file change, it changed itself when I ran the server or built or something - Not sure if I should commit that or what? cc @raisedadead?

@moT01 moT01 changed the title chore(.github): add zip for ci chore(.github): add zip for ci + render handbook/foundations section again Jun 24, 2026
@moT01
moT01 merged commit 687e2d8 into main Jul 1, 2026
5 checks passed
@ShaunSHamilton
ShaunSHamilton deleted the chore_ci-tooling-zip branch July 1, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants