chore(.github): add zip for ci + render handbook/foundations section again#4
Conversation
|
Sorry for the extra work, @raisedadead . Would you mind looking into this? I cannot use playwright locally. So, I am unsure if the snapshots just need updating, or this is indicative of another problem. |
|
I only looked at a few of the failing tests here - looks like a lot of screenshots are probably missing - |
|
k, I took another look at this. Turns out those screenshot filenames are correct. The issue was that the handbook/foundations section wasn't rendering: Not sure if that was intentional - probably not, since the files are there. The line I added makes them render again. Not sure what made the asset-kit.zip file change, it changed itself when I ran the server or built or something - Not sure if I should commit that or what? cc @raisedadead? |


Summary
zipis needed for all builds.Type of change
Pre-flight checklist
pnpm changesetadded (skip forchore/docs/test/ci-only PRs)pnpm test,pnpm typecheck,pnpm lint,pnpm format:checkclean locallypnpm test:visual:updateon macOS;Linux goldens regenerated via the Playwright Docker image — see
docs/runbooks/deploy-docs.md)
apps/docs/public/{_headers,_redirects,robots.txt}unchanged orrebaselined deliberately
docs/adr/README.md)