Repository navigation
Add checklists to notes, matching bullet list layout - #609
Open
fredrivett wants to merge 7 commits into
Open
fredrivett wants to merge 7 commits into
fredrivett wants to merge 7 commits into
Conversation
Task lists (`- [ ]` / `- [x]` in markdown) via TipTap's TaskList/TaskItem, nestable like other lists. Typing `[ ] ` at the start of a bullet item turns it into a checklist item, so `- [ ] ` works as in markdown — otherwise the brackets stayed as text and the note reopened as a checklist. Checklists are styled to match bullet lists exactly: the checkbox is drawn out of flow in the bullet's gutter, so indent, text start and row heights are unchanged when switching between the two. The shared styles also cover the inert box rendered markdown will draw. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Rendered markdown draws checklist items as an inert box styled like the editor's checkbox, instead of a clickable native input — which was also invalid inside the card's <button>. Applies to the note card, the note detail loading placeholder and the article card. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The card aspect estimate now strips a checklist's `[ ]`/`[x]` marker, since its checkbox sits in the bullet's gutter rather than taking text width. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A nested list sat a few px further from its parent than siblings do: the paragraph the editor wraps item text in kept its bottom margin above it. Neither the nested list nor that paragraph adds a gap now, so nested items follow the same item spacing — in the editor and on cards alike. A browser story measures every item gap across bullet, numbered and checklist nesting. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 17 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
The inert box was aria-hidden, leaving screen readers no way to tell checked items from unchecked. It now carries visually hidden "Checked:"/"Unchecked:" text (a checkbox role would be interactive, invalid inside the card button). Covers the article card too, and the list-rhythm story skips that text when measuring lines. Also adds a story typing `[ ] ` into a new item of an existing bullet list, and words the `- [ ] ` story's comment to match what it covers. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The emphasis strip removed a `*` bullet's marker before the block-marker strip ran, so `* [ ] item` kept its `[ ]` in the measured width. Strip block markers first. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Notes now support checklists (
- [ ]/- [x]markdown) in the editor, typed as[ ]or- [ ], with the checkbox drawn in the bullet's gutter so switching a list between bullets and checkboxes keeps the same indent, text start and row heights. Cards, the detail loading placeholder and article cards render checklist items as an inert box matching the editor's (a native input was clickable and invalid inside the card's<button>), and the card height estimate sizes them like bullet lists. Nested lists of any kind now keep the list's rhythm: a nested item sits the same gap below its parent as siblings do (the editor previously added ~3.5px above every nested list).Checklist
.env.example, in-app help,CONTRIBUTING.md, onboarding checklist), or N/A — README Done listcaptureServerException/ the error boundary, or N/A — N/Alearnskill, or N/A — N/ANotes
@tiptap/extension-listis now a direct dependency — it was already installed at the same version via StarterKit.- [ ]to start a checklist.🤖 Generated with Claude Code
Summary by cubic
Notes now support checklists (
- [ ]/- [x]in markdown). The checkbox is drawn in the bullet's gutter, so switching a list between bullets and checkboxes keeps the same indent, text start, and row heights. Typing[ ]at the start of a bullet item starts a checklist.Rendered markdown — note cards, the detail loading placeholder, and article cards — draws checklist items as inert boxes styled like the editor's checkbox; a native input was clickable and invalid inside the card's
<button>. Each box announces its checked state to screen readers via hidden text, since a checkbox role would be interactive inside the button. Card height estimates now strip the checkbox marker so checklists size exactly like bullet lists,*bullets included. Nested lists of any kind also keep the list's rhythm now: a nested item sits the same gap below its parent as siblings do (previously ~3.5px more).Notes
@tiptap/extension-listis now a direct dependency, previously pulled in at the same version via StarterKit.Written for commit 89582ee. Summary will update on new commits.