Prevent premature launches: disable continuous indexing on intake and tune beam-break pulse#11
Open
mechaniaccc wants to merge 2 commits intomainfrom
Open
Prevent premature launches: disable continuous indexing on intake and tune beam-break pulse#11mechaniaccc wants to merge 2 commits intomainfrom
mechaniaccc wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
IntakeCommandcall to passindexPower = 0instead of0.6(file:CommandTeleOp.java).IntakeCommandto reduce the beam-break feed pulse to180 ms, added separate pulse power capsINDEX_FEED_PULSE_POWER_INTAKE = 0.35andINDEX_FEED_PULSE_POWER_ACTIVE = 0.6, and implementedgetIndexPulsePower()which returns the appropriate capped pulse power (file:IntakeCommand.java).BeamBreakSubsystemas a properSubsystemBaseimplementation withisBeamBreakOn(...)andgetVoltage()methods and removed the embedded debug opmode (file:BeamBreakSubsystem.java).Testing
rg -n "leftTrigger\.whileActiveContinuous|new IntakeCommand\(feeder, \(\) -> beamBreak\.isBeamBreakOn\(" TeamCode/src/main/java/org/firstinspires/ftc/teamcode/CommandTeleOp.java, which found the modified binding../gradlew :TeamCode:compileDebugJavaWithJavac --console=plain, but Gradle wrapper download was blocked by the environment proxy (HTTP/1.1 403 Forbidden), so a full compile could not be completed in this environment.Codex Task