Reduce intake beam-break pulse power to avoid premature ring launch#10
Open
mechaniaccc wants to merge 2 commits intomainfrom
Open
Reduce intake beam-break pulse power to avoid premature ring launch#10mechaniaccc wants to merge 2 commits intomainfrom
mechaniaccc wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
IntakeCommand:INDEX_FEED_PULSE_POWER_INTAKE = 0.35for intake-mode (indexPower == 0) andINDEX_FEED_PULSE_POWER_ACTIVE = 0.6for active/indexing mode (indexPower != 0).getIndexPulsePower()to return the intake cap whenindexPoweris zero and the active cap (preserving sign) otherwise, and updatedexecute()to use the computed pulse power for the 180 ms beam-break pulse.180 ms) and the passthrough behavior when the beam is clear so shoot-time feeding still uses the commandedindexPower.BeamBreakSubsystemto a properSubsystemBaseimplementation and removed the embedded debug opmode so callers can useisBeamBreakOn(...)andgetVoltage().Testing
./gradlew :TeamCode:compileDebugJavaWithJavac --console=plain, but the Gradle wrapper download was blocked by the environment proxy and the compile step failed (HTTP/1.1 403 Forbidden).Codex Task