Skip to content

Remove editor settings from settings menu items for future implementation #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stijnpotters1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove editor settings from settings menu items for future implementation #542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions src/main/frontend/app/routes/settings/settings-menu-items.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import type { TreeItem } from 'react-complex-tree'
import React from 'react'
import WidgetIcon from '/icons/solar/Widget.svg?react'
import RulerCrossPenIcon from '/icons/solar/Ruler Cross Pen.svg?react'
import CodeIcon from '/icons/solar/Code.svg?react'
// import CodeIcon from '/icons/solar/Code.svg?react'
import GeneralSettings from '~/routes/settings/pages/general-settings'
import StudioSettings from '~/routes/settings/pages/studio-settings'
import ProjectSettings from './pages/project-settings'
Expand All @@ -16,10 +16,17 @@ export interface SettingsMenuItemData {
content?: React.FC
}

//todo: add editor settings and icon after there are settings to add there

const SettingsMenuItems = {
root: {
index: 'root',
children: ['general', 'projects', 'studio', 'editor'],
children: [
'general',
'projects',
'studio',
// 'editor'
],
data: {
title: '',
description: '',
Expand Down Expand Up @@ -51,14 +58,14 @@ const SettingsMenuItems = {
content: StudioSettings,
},
},
editor: {
index: 'editor',
data: {
title: 'Editor',
description: 'Editor settings',
icon: CodeIcon,
},
},
// editor: {
// index: 'editor',
// data: {
// title: 'Editor',
// description: 'Editor settings',
// icon: CodeIcon,
// },
// },
Comment on lines +61 to +68

@Matthbo Matthbo Jun 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// editor: {
// index: 'editor',
// data: {
// title: 'Editor',
// description: 'Editor settings',
// icon: CodeIcon,
// },
// },
/*editor: {
index: 'editor',
data: {
title: 'Editor',
description: 'Editor settings',
icon: CodeIcon,
},
},*/

@philipsens philipsens Jun 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any linter rules on this?

@Matthbo Matthbo Jun 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should configure this rule in all our projects?
https://eslint.org/docs/latest/rules/multiline-comment-style

@philipsens philipsens Jun 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New one: https://eslint.style/rules/multiline-comment-style

Actually, we shouldn't allow commented code at all. Only comments for docs.

} as Record<string, SettingsMenuItem>

export default SettingsMenuItems
Loading