chore(ci): Drop the FRAMER_ADMIN_SECRET declaration. - #696
Conversation
framer/workshop was the last caller passing it and stopped in framer/workshop#541. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approval recommended
The removed secret is no longer referenced in the repository and the workflow remains internally consistent after the declaration is dropped.
Pull request overview
This PR removes the now-unused FRAMER_ADMIN_SECRET secret declaration from the reusable “Submit Plugin” GitHub Actions workflow, aligning the workflow contract with the current release flow and reducing stale secret surface area.
Changes:
- Removed the
FRAMER_ADMIN_SECRETentry fromworkflow_call.secretsin.github/workflows/submit-plugin.yml.
File summaries
| File | Description |
|---|---|
| .github/workflows/submit-plugin.yml | Drops the unused FRAMER_ADMIN_SECRET secret declaration from the reusable workflow interface. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Context
Releases stopped using
FRAMER_ADMIN_SECRETin #691, but the declaration stayed so callers passing it wouldn't fail validation.framer/workshopwas the only one, and it stopped in framer/workshop#541, so the declaration can go.Changes
FRAMER_ADMIN_SECRETsecret from the reusable workflow. Nothing in the repo reads it now.The repo secret itself can be deleted separately, in this repo and in workshop.