fix: pin Node 24 and npm 11 in publish workflow - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Aligns the npm publish GitHub Actions workflow with trusted-publishing requirements by running on Node 24 and installing a fixed npm 11 major instead of floating
latest. This keeps publish CI deterministic while meeting the Node and npm CLI versions needed for OIDC trusted publishing.Key Changes & Features Implemented
CI / Publish Workflow
22.14to24(5dc43b4)npm install -g npm@latestwithnpm install -g npm@11so the trusted-publishing-capable CLI is pinned by major (5dc43b4)How to Test
.github/workflows/publish.ymland confirmnode-version: 24andnpm install -g npm@11.workflow_dispatch, run the Publish workflow and verify the Setup Node.js and Ensure npm CLI steps succeed.npm --versionin the job logs reports npm 11.x and that subsequent lint/test/build/publish steps still run as expected when the package version is unpublished.