fix: 안내 생성 실패를 HR 수동 검토 화면에 연결 - #345
Draft
hywznn wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
왜 필요한가요?
Server #162/#179 이후 Renewal 실행은 근로자 안내 생성에 실패하면
guide_review_required=true와guide_failure_code를 반환하고, 안전하지 않은 안내 초안과 발송 링크를 만들지 않습니다.하지만 Client는 두 필드를 응답 타입에 포함하지 않아 실패 상태를 버리고 있었습니다. 또한 저장된 초안이 없으면 브라우저가 한국어 안내문을 자동으로 채워, 베트남어 등 다른 언어를 사용하는 근로자에게 잘못된 문구가 확정될 수 있었습니다.
무엇이 바뀌나요?
1. Server 계약 수용
RenewalExecutionResponse에guide_review_required,guide_failure_code추가2. 실패 시 Fail-closed UI
business_data.renewal_execution을 읽어 새로고침 후에도 검토 상태 복원3. 대상 언어 기반 수동 초안
preferred_language를 새 초안의 기본 언어로 사용동작 흐름
영향 범위
검증
routes.tsxFast Refresh 경고 13개git diff --check: 통과확인 체크리스트
Closes #343
관련: fowoco/server#162, fowoco/server#179, fowoco/ai#44
Supersedes #344 — 브랜치 명명 규칙을
feat/로 맞추기 위해 대체합니다.