🔧 Add argument validations #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
ani300
reviewed
Apr 28, 2025
| type=str, | ||
| default=None, | ||
| help="The model variant (configuration) to benchmark. E.g. 7b, 13b, 70b.", | ||
| required=True, |
Contributor
There was a problem hiding this comment.
you need either model_variant or model_path, but you can can have architecture and model_path without variant for example
Contributor
Author
There was a problem hiding this comment.
variant seems to be required for this script, since it uses this information for creating file name prefixes etc: https://github.com/foundation-model-stack/aiu-fms-testing-utils/pull/38/files#diff-f2d7f13363f393d17bef3e70f84983fd1283ac80f0a826e92596151c753c030cL111
So I thought of making it explicit.
gkumbhat
force-pushed
the
minor_validations
branch
2 times, most recently
from
0a3641c to
b18373e
Compare
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
gkumbhat
force-pushed
the
minor_validations
branch
from
b18373e to
f01056e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
sharegpt_path, otherwise,args.sharegpt_pathwill returnNonewhich is causing exception at https://github.com/foundation-model-stack/aiu-fms-testing-utils/blob/main/aiu_fms_testing_utils/utils/__init__.py#L89