fix: wait for ephemeral server to listen before dispatching request#890
Open
aguidrevitch wants to merge 1 commit into
Open
fix: wait for ephemeral server to listen before dispatching request#890aguidrevitch wants to merge 1 commit into
aguidrevitch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #255
When an app is passed to supertest, request(app) starts a temporary server with app.listen(0) and builds the URL from server.address().port. The port is instantly ready before the server emits 'listening', so if superagent dispatches in that window the request misses the app and returns a 404. That's why the route in #255 works from other clients but intermittently 404s under supertest. That's why starting a server outside of the supertest (with waiting for 'listening' event) also fixes the issue.
This PR waits for the server's 'listening' event before dispatching, but only when supertest started the server and it isn't listening yet. A regression test covers the race window, fails without fix, passes with the fix.
Checklist