feat: Add --force-reaudit to re-audit Aviator-processed issues - #1082
Merged
Conversation
…emediationProcessor
kireetivar
marked this pull request as ready for review
August 27, 2026 09:22
rsenden
requested changes
Aug 27, 2026
rsenden
left a comment
Contributor
There was a problem hiding this comment.
Only focusing on code quality, three minor comments.
| private final AuditFprOptions options; | ||
| private final Set<String> resultTagIds; | ||
|
|
||
| public IssueAuditor(List<Vulnerability> vulnerabilities, AuditProcessor auditProcessor, Map<String, AuditIssue> auditIssueMap, |
Contributor
There was a problem hiding this comment.
Although already present before this PR, given the number of constructor arguments, probably better to use @Builder?
| contextIndex++; // Skip empty context lines | ||
| continue; | ||
| } | ||
| private static Integer findContextMatchStart(List<String> normalizedSource, List<String> normalizedContext, |
Contributor
There was a problem hiding this comment.
This looks like a fairly long method (although difficult to see from PR view); any way to shorten/split this method?
Contributor
Author
There was a problem hiding this comment.
It's about 20 lines. I still added one helper for the blank-start skip
| return noFilterSet; | ||
| } | ||
|
|
||
| boolean isForceReaudit() { |
Contributor
There was a problem hiding this comment.
Better to use @Getter on option declaration, but why do we need this getter anyway? I think it's only used in a unit test, which could use setAccessible to read the field value directly.
rsenden
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--force-reaudittofcli aviator ssc auditso issues Aviator already processed can be sent again.Behavior
audit.xmlTagHistoryusername on result tags (Analysis, Auditor Status, FoD, filter-template Analysis id,--tag-mappingGUID). Not “any Auditor Status value.”Fortify Remediation Aviator,Fortify Aviator,Core SAST Aviator.--tag-mappingonto Auditor Status does not make force-reaudit a no-op when Aviator wrote that tag.Preflight
q=audited:falseunder--force-reaudit; otherwise Analysis-tagged Aviator issues skip the whole AV.Tests:
IssueAuditorTest,AuditProcessorLastTagUsernamesTest,AviatorSSCAuditHelperTest.Commit: