-
Notifications
You must be signed in to change notification settings - Fork 148
Checking FLINT version #703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
For sensible runtimes we'd need to cache the flint build, as you do for the macos tests, for the linux jobs. |
92f1868 to
39e2dd5
Compare
|
Rebased onto #622. |
39e2dd5 to
db91484
Compare
|
If we require at least v3.2.0, we could also remove the "workaround" here: form/sources/flintinterface.cc Lines 1724 to 1751 in e3eeea3
|
db91484 to
ed1328f
Compare
Right. I have pushed a commit that completely removes the workaround. |
|
I don't think so, it would be straightforward to add back in if it becomes necessary in the future. |
|
At this point we should also recommend flint >=3.2.0 (and zstd) in the README.md and INSTALL files. |
Disallow FLINT versions earlier than 3.2.0 by performing a preprocessor-based check during configure.
Add a runtime check that disallows FLINT versions earlier than 3.2.0. Note that the version check is also performed during the configure step. A runtime failure typically indicates that an incorrect shared library was linked.
We now require FLINT >= 3.2.0. The workaround is no longer necessary.
ce61f51 to
7813cf6
Compare
|
TODO: |
This PR adds checks both at configuration and at runtime to require FLINT 3.2.0 or later. Resolves #679.
Note: Many test jobs are currently failing due to old FLINT versions.Update: This PR depends on: