Conversation
This reverts commit 1191c96.
MichaelHillcox
requested changes
May 8, 2024
Contributor
MichaelHillcox
left a comment
MichaelHillcox
left a comment
There was a problem hiding this comment.
Overall, this is looking good and is going in the right direction :D Just some questions and comments about some of the implementations
MichaelHillcox
approved these changes
May 8, 2024
Contributor
|
Looks like we're just blocked by some failing unit tests and docker building |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.