Merged
Conversation
Member
|
Looks good, but we need some tests also |
Contributor
Author
|
Okay I have implemented some tests now, please tell me if anything is missing not up to standards :) |
gastaldi
reviewed
Jan 4, 2026
impl/src/main/java/org/jboss/forge/roaster/model/impl/InitializerImpl.java
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds API support for static initializers to Roaster, enabling users to add, retrieve, and remove initializer blocks for Java classes, enums, and records. This addresses issue #237 by introducing a comprehensive initializer management API.
Key changes:
- Introduced new API interfaces (
Initializer,InitializerHolder,InitializerSource,InitializerHolderSource) to represent and manage initializer blocks - Implemented initializer support in
JavaClassImpl,JavaEnumImpl, andJavaRecordImplwith methods to add, get, and remove initializers - Added comprehensive test coverage for initializer functionality across all three Java type implementations
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
api/src/main/java/org/jboss/forge/roaster/model/Initializer.java |
New interface defining the base contract for initializer blocks with body retrieval |
api/src/main/java/org/jboss/forge/roaster/model/InitializerHolder.java |
New interface for types that can contain initializers, providing getInitializers() |
api/src/main/java/org/jboss/forge/roaster/model/source/InitializerSource.java |
Source-level initializer interface extending Initializer with setBody() capability |
api/src/main/java/org/jboss/forge/roaster/model/source/InitializerHolderSource.java |
Source-level interface for adding and removing initializers |
api/src/main/java/org/jboss/forge/roaster/model/JavaClass.java |
Updated to extend InitializerHolder interface |
api/src/main/java/org/jboss/forge/roaster/model/JavaEnum.java |
Updated to extend InitializerHolder interface |
api/src/main/java/org/jboss/forge/roaster/model/JavaRecord.java |
Updated to extend InitializerHolder interface |
api/src/main/java/org/jboss/forge/roaster/model/source/JavaClassSource.java |
Updated to extend InitializerHolderSource interface |
api/src/main/java/org/jboss/forge/roaster/model/source/JavaEnumSource.java |
Updated to extend InitializerHolderSource interface |
api/src/main/java/org/jboss/forge/roaster/model/source/JavaRecordSource.java |
Updated to extend InitializerHolderSource interface |
impl/src/main/java/org/jboss/forge/roaster/model/impl/InitializerImpl.java |
New implementation class handling initializer body parsing, static modifier management, and JavaDoc support |
impl/src/main/java/org/jboss/forge/roaster/model/impl/JavaClassImpl.java |
Implements initializer management methods for classes |
impl/src/main/java/org/jboss/forge/roaster/model/impl/JavaEnumImpl.java |
Implements initializer management methods for enums, includes formatting fix |
impl/src/main/java/org/jboss/forge/roaster/model/impl/JavaRecordImpl.java |
Implements initializer management methods for records |
tests/src/test/java/org/jboss/forge/test/roaster/model/JavaClassInitializerTest.java |
Tests for class initializer static flag operations |
tests/src/test/java/org/jboss/forge/test/roaster/model/JavaEnumInitializerTest.java |
Tests for enum initializer static flag operations |
tests/src/test/java/org/jboss/forge/test/roaster/model/JavaRecordInitializerTest.java |
Tests for record initializer static flag operations |
tests/src/test/java/org/jboss/forge/test/roaster/model/InitializerBodyTest.java |
Tests for initializer body manipulation including lambdas and complex statements |
tests/src/test/java/org/jboss/forge/test/roaster/model/InitializerImplementationTest.java |
Tests for initializer validation and error handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
impl/src/main/java/org/jboss/forge/roaster/model/impl/InitializerImpl.java
Show resolved
Hide resolved
impl/src/main/java/org/jboss/forge/roaster/model/impl/JavaClassImpl.java
Show resolved
Hide resolved
api/src/main/java/org/jboss/forge/roaster/model/source/InitializerHolderSource.java
Show resolved
Hide resolved
tests/src/test/java/org/jboss/forge/test/roaster/model/JavaClassInitializerTest.java
Show resolved
Hide resolved
tests/src/test/java/org/jboss/forge/test/roaster/model/JavaEnumInitializerTest.java
Show resolved
Hide resolved
tests/src/test/java/org/jboss/forge/test/roaster/model/JavaRecordInitializerTest.java
Show resolved
Hide resolved
tests/src/test/java/org/jboss/forge/test/roaster/model/JavaClassInitializerTest.java
Outdated
Show resolved
Hide resolved
tests/src/test/java/org/jboss/forge/test/roaster/model/JavaEnumInitializerTest.java
Outdated
Show resolved
Hide resolved
As introduced in forge#387
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
|
Thanks! I'll cut a release later today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an api to Roaster which allows to add/remove/get static initializers of enums, classes and records.
This should close #237